third_party/WebKit/LayoutTests/app_banner/app-banner-event-dispatch.html - Issue 2393513004: Convert app banners to use Mojo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/app_banner/app-banner-event-dispatch.html

Issue 2393513004: Convert app banners to use Mojo. (Closed)

Patch Set: Add TODO Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/renderer/layout_test/layout_test_content_renderer_client.cc ('k') | third_party/WebKit/LayoutTests/app_banner/app-banner-event-prompt.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/app_banner/app-banner-event-dispatch.html

diff --git a/third_party/WebKit/LayoutTests/app_banner/app-banner-event-dispatch.html b/third_party/WebKit/LayoutTests/app_banner/app-banner-event-dispatch.html

index 5286e4e540d4dd965e6d27bec6863ec7e9a493ae..cc49e7243d64eeedf7a427bf21f0da38cb3212dd 100644

--- a/third_party/WebKit/LayoutTests/app_banner/app-banner-event-dispatch.html

+++ b/third_party/WebKit/LayoutTests/app_banner/app-banner-event-dispatch.html

@@ -47,14 +47,14 @@ function banner_test(index) {

});

window.addEventListener('beforeinstallprompt', event_handler);

- testRunner.dispatchBeforeInstallPromptEvent(index, ['foo', 'bar'], t.step_func(function(result) {

+ testRunner.dispatchBeforeInstallPromptEvent(['foo', 'bar'], t.step_func(function(result) {

assert_equals(result, test_case.cancel, 'Event canceled');

if (test_case.cancel) {

banner_test(index + 1);

t.done();

return;

}

- testRunner.resolveBeforeInstallPromptPromise(index, test_case.platform);

+ testRunner.resolveBeforeInstallPromptPromise(test_case.platform);

}));

}, test_case.name);

}