Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10605)

Unified Diff: chrome/common/render_messages.h

Issue 2393513004: Convert app banners to use Mojo. (Closed)
Patch Set: Add TODO Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_manager_desktop.cc ('k') | chrome/renderer/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/render_messages.h
diff --git a/chrome/common/render_messages.h b/chrome/common/render_messages.h
index e90ed2d4cc525daed4bbbf8f6e01121d5575f318..bdd10d4a5129f322d48286e757c0808b1c219dd3 100644
--- a/chrome/common/render_messages.h
+++ b/chrome/common/render_messages.h
@@ -25,7 +25,6 @@
#include "ipc/ipc_message_macros.h"
#include "ipc/ipc_platform_file.h"
#include "ppapi/features/features.h"
-#include "third_party/WebKit/public/platform/modules/app_banner/WebAppBannerPromptReply.h"
#include "third_party/WebKit/public/web/WebConsoleMessage.h"
#include "third_party/WebKit/public/web/WebWindowFeatures.h"
#include "ui/base/window_open_disposition.h"
@@ -189,9 +188,6 @@ IPC_STRUCT_TRAITS_BEGIN(WebApplicationInfo)
IPC_STRUCT_TRAITS_MEMBER(mobile_capable)
IPC_STRUCT_TRAITS_END()
-IPC_ENUM_TRAITS_MAX_VALUE(blink::WebAppBannerPromptReply,
- blink::WebAppBannerPromptReply::Cancel)
-
//-----------------------------------------------------------------------------
// RenderView messages
// These are messages sent from the browser to the renderer process.
@@ -502,21 +498,6 @@ IPC_MESSAGE_ROUTED0(ChromeViewHostMsg_ShowFlashPermissionBubble)
IPC_MESSAGE_ROUTED1(ChromeViewHostMsg_CouldNotLoadPlugin,
base::FilePath /* plugin_path */)
-// Asks the renderer whether an app banner should be shown. It will reply with
-// ChromeViewHostMsg_AppBannerPromptReply.
-IPC_MESSAGE_ROUTED2(ChromeViewMsg_AppBannerPromptRequest,
- int /* request_id */,
- std::string /* platform */)
-
-// Tells the renderer that a banner has been accepted.
-IPC_MESSAGE_ROUTED2(ChromeViewMsg_AppBannerAccepted,
- int32_t /* request_id */,
- std::string /* platform */)
-
-// Tells the renderer that a banner has been dismissed.
-IPC_MESSAGE_ROUTED1(ChromeViewMsg_AppBannerDismissed,
- int32_t /* request_id */)
-
// Notification that the page has an OpenSearch description document
// associated with it.
IPC_MESSAGE_ROUTED2(ChromeViewHostMsg_PageHasOSDD,
@@ -625,17 +606,6 @@ IPC_SYNC_MESSAGE_CONTROL0_1(ChromeViewHostMsg_IsCrashReportingEnabled,
bool /* enabled */)
#endif
-// Tells the browser process whether the web page wants the banner to be shown.
-// This is a reply from ChromeViewMsg_AppBannerPromptRequest.
-IPC_MESSAGE_ROUTED3(ChromeViewHostMsg_AppBannerPromptReply,
- int /* request_id */,
- blink::WebAppBannerPromptReply /* reply */,
- std::string /* referrer */)
-
-// Tells the browser to restart the app banner display pipeline.
-IPC_MESSAGE_ROUTED1(ChromeViewHostMsg_RequestShowAppBanner,
- int32_t /* request_id */)
-
// Sent by the renderer to indicate that a fields trial has been activated.
IPC_MESSAGE_CONTROL1(ChromeViewHostMsg_FieldTrialActivated,
std::string /* name */)
« no previous file with comments | « chrome/browser/banners/app_banner_manager_desktop.cc ('k') | chrome/renderer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698