Chromium Code Reviews| Index: third_party/WebKit/Source/modules/app_banner/AppBannerController.h |
| diff --git a/third_party/WebKit/Source/modules/app_banner/AppBannerController.h b/third_party/WebKit/Source/modules/app_banner/AppBannerController.h |
| index cef446cd5dd592df7557a85279f1b02e07cbed92..381b0039c4a187f5cd8c5c75209c9f80bf404866 100644 |
| --- a/third_party/WebKit/Source/modules/app_banner/AppBannerController.h |
| +++ b/third_party/WebKit/Source/modules/app_banner/AppBannerController.h |
| @@ -6,29 +6,29 @@ |
| #define AppBannerController_h |
| #include "modules/ModulesExport.h" |
| +#include "platform/heap/Persistent.h" |
| +#include "public/platform/modules/app_banner/app_banner.mojom-blink.h" |
| #include "wtf/Allocator.h" |
| -#include "wtf/Noncopyable.h" |
| +#include "wtf/Vector.h" |
| namespace blink { |
| -enum class WebAppBannerPromptReply; |
| class LocalFrame; |
| -class WebAppBannerClient; |
| -class WebString; |
| -template <typename T> |
| -class WebVector; |
| - |
| -// FIXME: unless userChoice ends up implemented, this class should not exist and |
| -// a regular static method could be used instead. |
| -class MODULES_EXPORT AppBannerController final { |
| - STATIC_ONLY(AppBannerController); |
| +class MODULES_EXPORT AppBannerController final |
| + : public mojom::blink::AppBannerController { |
| public: |
| - static void willShowInstallBannerPrompt(int requestId, |
| - WebAppBannerClient*, |
| - LocalFrame*, |
| - const WebVector<WebString>& platforms, |
| - WebAppBannerPromptReply*); |
| + explicit AppBannerController(LocalFrame*); |
| + |
| + static void create(LocalFrame*, mojom::blink::AppBannerControllerRequest); |
| + |
| + void BannerPromptRequest(mojom::blink::AppBannerServicePtr, |
| + mojom::blink::AppBannerEventRequest, |
| + const Vector<String>& platforms, |
| + const BannerPromptRequestCallback&) override; |
| + |
| + private: |
| + WeakPersistent<LocalFrame> m_frame; |
|
haraken
2016/10/19 09:57:05
Why does this need to be weak?
Does AppBannerCont
dominickn
2016/10/20 04:54:57
Changed to Persistent.
|
| }; |
| } // namespace blink |