chrome/renderer/chrome_content_renderer_client.h - Issue 2393513004: Convert app banners to use Mojo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client.h

Issue 2393513004: Convert app banners to use Mojo. (Closed)

Patch Set: Rebase. init() can cause frames to detach Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/chrome_content_renderer_client.h

diff --git a/chrome/renderer/chrome_content_renderer_client.h b/chrome/renderer/chrome_content_renderer_client.h

index f3665481e50f26da38ade7138dc756c5376f340f..0771c2ce3fac51612a4a794babfe700594e8c72c 100644

--- a/chrome/renderer/chrome_content_renderer_client.h

+++ b/chrome/renderer/chrome_content_renderer_client.h

@@ -169,8 +169,6 @@ class ChromeContentRendererClient : public content::ContentRendererClient {

void RecordRappor(const std::string& metric,

const std::string& sample) override;

void RecordRapporURL(const std::string& metric, const GURL& url) override;

- std::unique_ptr<blink::WebAppBannerClient> CreateAppBannerClient(

- content::RenderFrame* render_frame) override;

void AddImageContextMenuProperties(

const blink::WebURLResponse& response,

std::map<std::string, std::string>* properties) override;