Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1467)

Unified Diff: chrome/renderer/chrome_render_frame_observer.cc

Issue 2393513004: Convert app banners to use Mojo. (Closed)
Patch Set: Fix Win clang compile Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_render_frame_observer.cc
diff --git a/chrome/renderer/chrome_render_frame_observer.cc b/chrome/renderer/chrome_render_frame_observer.cc
index 977faf83e927caa2d683a55984e439d3115329fa..0e620de38684eab20ffbd5307d3c3dd389bb9775 100644
--- a/chrome/renderer/chrome_render_frame_observer.cc
+++ b/chrome/renderer/chrome_render_frame_observer.cc
@@ -30,7 +30,6 @@
#include "skia/ext/image_operations.h"
#include "third_party/WebKit/public/platform/WebImage.h"
#include "third_party/WebKit/public/platform/WebURLRequest.h"
-#include "third_party/WebKit/public/platform/modules/app_banner/WebAppBannerPromptReply.h"
#include "third_party/WebKit/public/web/WebDataSource.h"
#include "third_party/WebKit/public/web/WebDocument.h"
#include "third_party/WebKit/public/web/WebElement.h"
@@ -107,6 +106,15 @@ SkBitmap Downscale(const blink::WebImage& image,
} // namespace
+// static
+void ChromeRenderFrameObserver::BindBannerClient(
+ ChromeRenderFrameObserver* observer,
+ mojo::InterfaceRequest<blink::mojom::AppBannerClient> request) {
+ observer->banner_binding_.reset(
+ new mojo::Binding<blink::mojom::AppBannerClient>(observer,
+ std::move(request)));
+}
+
ChromeRenderFrameObserver::ChromeRenderFrameObserver(
content::RenderFrame* render_frame)
: content::RenderFrameObserver(render_frame),
@@ -149,8 +157,6 @@ bool ChromeRenderFrameObserver::OnMessageReceived(const IPC::Message& message) {
IPC_MESSAGE_HANDLER(PrintMsg_PrintNodeUnderContextMenu,
OnPrintNodeUnderContextMenu)
#endif
- IPC_MESSAGE_HANDLER(ChromeViewMsg_AppBannerPromptRequest,
- OnAppBannerPromptRequest)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
@@ -240,14 +246,13 @@ void ChromeRenderFrameObserver::OnSetClientSidePhishingDetection(
#endif
}
-void ChromeRenderFrameObserver::OnAppBannerPromptRequest(
+void ChromeRenderFrameObserver::BannerPromptRequest(
int request_id,
- const std::string& platform) {
- // App banner prompt requests are handled in the general chrome render frame
- // observer, not the AppBannerClient, as the AppBannerClient is created lazily
- // by blink and may not exist when the request is sent.
- blink::WebAppBannerPromptReply reply = blink::WebAppBannerPromptReply::None;
- blink::WebString web_platform(base::UTF8ToUTF16(platform));
+ const mojo::String& platform,
+ const BannerPromptRequestCallback& callback) {
+ blink::mojom::AppBannerPromptReply reply =
+ blink::mojom::AppBannerPromptReply::NONE;
+ blink::WebString web_platform(base::UTF8ToUTF16(platform.get()));
blink::WebVector<blink::WebString> web_platforms(&web_platform, 1);
blink::WebLocalFrame* frame = render_frame()->GetWebFrame();
@@ -260,8 +265,7 @@ void ChromeRenderFrameObserver::OnAppBannerPromptRequest(
frame->document().referrerPolicy(), GURL(),
frame->document().outgoingReferrer()).utf8();
- Send(new ChromeViewHostMsg_AppBannerPromptReply(
- routing_id(), request_id, reply, referrer));
+ callback.Run(request_id, reply, referrer);
}
void ChromeRenderFrameObserver::DidFinishLoad() {

Powered by Google App Engine
This is Rietveld 408576698