Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: third_party/WebKit/public/web/WebLocalFrame.h

Issue 2393513004: Convert app banners to use Mojo. (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebLocalFrame.h
diff --git a/third_party/WebKit/public/web/WebLocalFrame.h b/third_party/WebKit/public/web/WebLocalFrame.h
index 69940c6f0432a1a77dcfec87fd7dd47e04b2459d..1048450aa57a570ba96cefd07093c58a6485cbcf 100644
--- a/third_party/WebKit/public/web/WebLocalFrame.h
+++ b/third_party/WebKit/public/web/WebLocalFrame.h
@@ -9,10 +9,15 @@
#include "WebFrame.h"
#include "WebFrameLoadType.h"
#include "WebHistoryItem.h"
+#include "mojo/public/cpp/system/message_pipe.h"
#include "public/platform/WebCachePolicy.h"
namespace blink {
+namespace mojom {
+enum class AppBannerPromptReply;
+}
+
class WebAutofillClient;
class WebContentSettingsClient;
class WebDevToolsAgent;
@@ -23,7 +28,6 @@ class WebFrameWidget;
class WebRange;
class WebScriptExecutionCallback;
class WebSuspendableTask;
-enum class WebAppBannerPromptReply;
enum class WebCachePolicy;
enum class WebSandboxFlags;
enum class WebTreeScopeType;
@@ -305,13 +309,15 @@ class WebLocalFrame : public WebFrame {
// App banner -------------------------------------------------------------
- // Request to show an application install banner for the given |platforms|.
- // The implementation can request the embedder to cancel the call by setting
- // |cancel| to true.
+ // Request to show an app install banner for the given |platforms|. The
+ // ScopedMessagePipeHandles represent the raw connections to and from an
+ // AppBannerService. Setting |AppBannerPromptReply| to
+ // mojom::AppBannerPromptReply::CANCEL will cancel the banner.
virtual void willShowInstallBannerPrompt(
- int requestId,
+ mojo::ScopedMessagePipeHandle serviceHandle,
+ mojo::ScopedMessagePipeHandle eventHandle,
const WebVector<WebString>& platforms,
- WebAppBannerPromptReply*) = 0;
+ mojom::AppBannerPromptReply*) = 0;
// Image reload -----------------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698