Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Unified Diff: third_party/WebKit/Source/modules/app_banner/AppBannerController.h

Issue 2393513004: Convert app banners to use Mojo. (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/app_banner/AppBannerController.h
diff --git a/third_party/WebKit/Source/modules/app_banner/AppBannerController.h b/third_party/WebKit/Source/modules/app_banner/AppBannerController.h
index cef446cd5dd592df7557a85279f1b02e07cbed92..91361bf5810dd2e9c06294f0f526ea359cc3e77c 100644
--- a/third_party/WebKit/Source/modules/app_banner/AppBannerController.h
+++ b/third_party/WebKit/Source/modules/app_banner/AppBannerController.h
@@ -6,14 +6,16 @@
#define AppBannerController_h
#include "modules/ModulesExport.h"
+#include "mojo/public/cpp/system/message_pipe.h"
#include "wtf/Allocator.h"
-#include "wtf/Noncopyable.h"
namespace blink {
-enum class WebAppBannerPromptReply;
+namespace mojom {
+enum class AppBannerPromptReply;
+}
+
class LocalFrame;
-class WebAppBannerClient;
class WebString;
template <typename T>
class WebVector;
@@ -24,11 +26,12 @@ class MODULES_EXPORT AppBannerController final {
STATIC_ONLY(AppBannerController);
public:
- static void willShowInstallBannerPrompt(int requestId,
- WebAppBannerClient*,
- LocalFrame*,
- const WebVector<WebString>& platforms,
- WebAppBannerPromptReply*);
+ static void willShowInstallBannerPrompt(
dcheng 2016/10/07 07:03:16 Or a TODO here would work as well (maybe better, s
+ LocalFrame*,
+ mojo::ScopedMessagePipeHandle serviceHandle,
+ mojo::ScopedMessagePipeHandle eventHandle,
+ const WebVector<WebString>& platforms,
+ mojom::AppBannerPromptReply*);
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698