third_party/WebKit/LayoutTests/app_banner/app-banner-event-prompt.html - Issue 2393513004: Convert app banners to use Mojo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/app_banner/app-banner-event-prompt.html

Issue 2393513004: Convert app banners to use Mojo. (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/chrome_render_frame_observer.cc ('K') | « third_party/WebKit/LayoutTests/app_banner/app-banner-event-dispatch.html ('k') | third_party/WebKit/LayoutTests/app_banner/testrunner-resolve-crash.html » ('j') | third_party/WebKit/Source/modules/app_banner/AppBannerController.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/app_banner/app-banner-event-prompt.html

diff --git a/third_party/WebKit/LayoutTests/app_banner/app-banner-event-prompt.html b/third_party/WebKit/LayoutTests/app_banner/app-banner-event-prompt.html

index f328d6af1343dd8cefe3f6cc938c2cb1eabd973c..9ba299334ed93f509b0a9b070342d9ed65b62e31 100644

--- a/third_party/WebKit/LayoutTests/app_banner/app-banner-event-prompt.html

+++ b/third_party/WebKit/LayoutTests/app_banner/app-banner-event-prompt.html

@@ -114,8 +114,8 @@ function prompt_test(index) {

});

window.addEventListener('beforeinstallprompt', event_handler);

- testRunner.dispatchBeforeInstallPromptEvent(index, ['foo', 'bar'], t.step_func(function(result) {

- testRunner.resolveBeforeInstallPromptPromise(index, test_case.platform);

+ testRunner.dispatchBeforeInstallPromptEvent(['foo', 'bar'], t.step_func(function(result) {

+ testRunner.resolveBeforeInstallPromptPromise(test_case.platform);

}));

// Test that firing prompt() outside of the handler resolves or rejects correctly.