Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: components/test_runner/test_runner.cc

Issue 2393513004: Convert app banners to use Mojo. (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/test_runner.cc
diff --git a/components/test_runner/test_runner.cc b/components/test_runner/test_runner.cc
index 86185b48a8917e53e83714249e615ee18fc4d34a..d953be0fade68ed15451c29a1be67f02f8fd0c3a 100644
--- a/components/test_runner/test_runner.cc
+++ b/components/test_runner/test_runner.cc
@@ -14,7 +14,6 @@
#include "base/strings/string_number_conversions.h"
#include "base/strings/stringprintf.h"
#include "build/build_config.h"
-#include "components/test_runner/app_banner_client.h"
#include "components/test_runner/layout_and_paint_async_then.h"
#include "components/test_runner/layout_dump.h"
#include "components/test_runner/mock_content_settings_client.h"
@@ -129,7 +128,6 @@ class TestRunnerBindings : public gin::Wrappable<TestRunnerBindings> {
void DidNotAcquirePointerLock();
void DisableMockScreenOrientation();
void DispatchBeforeInstallPromptEvent(
- int request_id,
const std::vector<std::string>& event_platforms,
v8::Local<v8::Function> callback);
void DumpAsMarkup();
@@ -184,8 +182,7 @@ class TestRunnerBindings : public gin::Wrappable<TestRunnerBindings> {
void RemoveWebPageOverlay();
void ResetDeviceLight();
void ResetTestHelperControllers();
- void ResolveBeforeInstallPromptPromise(int request_id,
- const std::string& platform);
+ void ResolveBeforeInstallPromptPromise(const std::string& platform);
void RunIdleTasks(v8::Local<v8::Function> callback);
void SendBluetoothManualChooserEvent(const std::string& event,
const std::string& argument);
@@ -1460,23 +1457,21 @@ void TestRunnerBindings::SetPermission(const std::string& name,
}
void TestRunnerBindings::DispatchBeforeInstallPromptEvent(
- int request_id,
const std::vector<std::string>& event_platforms,
v8::Local<v8::Function> callback) {
if (!view_runner_)
return;
- return view_runner_->DispatchBeforeInstallPromptEvent(
- request_id, event_platforms, callback);
+ return view_runner_->DispatchBeforeInstallPromptEvent(event_platforms,
+ callback);
}
void TestRunnerBindings::ResolveBeforeInstallPromptPromise(
- int request_id,
const std::string& platform) {
if (!runner_)
return;
- runner_->ResolveBeforeInstallPromptPromise(request_id, platform);
+ runner_->ResolveBeforeInstallPromptPromise(platform);
}
void TestRunnerBindings::RunIdleTasks(v8::Local<v8::Function> callback) {
@@ -2670,11 +2665,8 @@ void TestRunner::SetPermission(const std::string& name,
}
void TestRunner::ResolveBeforeInstallPromptPromise(
- int request_id,
const std::string& platform) {
- if (!test_interfaces_->GetAppBannerClient())
- return;
- test_interfaces_->GetAppBannerClient()->ResolvePromise(request_id, platform);
+ delegate_->ResolveBeforeInstallPromptPromise(platform);
}
void TestRunner::SetPOSIXLocale(const std::string& locale) {

Powered by Google App Engine
This is Rietveld 408576698