third_party/WebKit/Source/modules/app_banner/OWNERS - Issue 2393513004: Convert app banners to use Mojo.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/app_banner/OWNERS

Issue 2393513004: Convert app banners to use Mojo. (Closed)

Patch Set: Nits Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	1 dominickn@chromium.org
	esprehn 2016/10/25 03:17:43 Generally I've been telling people we're not going Generally I've been telling people we're not going to add OWNERS to modules unless they're familiar with blink and web platform. How comfortable are you with WTF, Oilpan, and web platform process? :) dominickn 2016/10/25 08:01:18 I own all the other banner code, and have made pre Show quoted text On 2016/10/25 03:17:43, esprehn wrote: > Generally I've been telling people we're not going to add OWNERS to modules > unless they're familiar with blink and web platform. How comfortable are you > with WTF, Oilpan, and web platform process? :) I own all the other banner code, and have made pretty much all the substantive changes here over the last year. I feel comfortable with what comes in and out of this module, and I keep up with blink-dev and the architectural changes and processes. This CL is pretty cutting edge given that it's the first one to expose a service from Blink. However, if you're strongly opposed I'll remove myself before landing. :)
1 mlamouri@chromium.org	2 mlamouri@chromium.org

OLD	NEW