Convert app banners to use Mojo.

third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/app_banner/AppBannerController.h"
 
 #include "core/EventTypeNames.h"
-#include "core/dom/Document.h"
 #include "core/frame/DOMWindow.h"
 #include "core/frame/LocalFrame.h"
 #include "modules/app_banner/BeforeInstallPromptEvent.h"
 #include "public/platform/WebVector.h"
-#include "public/platform/modules/app_banner/WebAppBannerClient.h"
-#include "public/platform/modules/app_banner/WebAppBannerPromptReply.h"
+#include "third_party/WebKit/public/platform/modules/app_banner/app_banner.mojom-blink.h"
 
 namespace blink {
 
 // static
 void AppBannerController::willShowInstallBannerPrompt(
+    LocalFrame* frame,
     int requestId,
-    WebAppBannerClient* client,
-    LocalFrame* frame,
     const WebVector<WebString>& platforms,
-    WebAppBannerPromptReply* reply) {
+    mojom::AppBannerPromptReply* reply) {

[Sam McNally, 2016/10/06 07:17:43]

Could the reply be a return value instead?

[dominickn, 2016/10/06 22:58:12]

I'd rather leave it so that it's consistently an output argument the whole way
through, given it has to be sent back through a callback anyway.

Also, making it a return value means that I have to include the mojom-blink.h
file in WebLocalFrame.h, instead of just forward declaring it.

   Vector<String> wtfPlatforms;
   for (const WebString& platform : platforms)
     wtfPlatforms.append(platform);
 
   // dispatchEvent() returns whether the default behavior can happen. In other
   // words, it returns false if preventDefault() was called.
-  *reply =
-      frame->domWindow()->dispatchEvent(BeforeInstallPromptEvent::create(
-          EventTypeNames::beforeinstallprompt, frame->document(), wtfPlatforms,
-          requestId, client)) == DispatchEventResult::NotCanceled
-          ? WebAppBannerPromptReply::None
-          : WebAppBannerPromptReply::Cancel;
+  *reply = frame->domWindow()->dispatchEvent(BeforeInstallPromptEvent::create(
+               EventTypeNames::beforeinstallprompt, frame, requestId,
+               wtfPlatforms)) == DispatchEventResult::NotCanceled
+               ? mojom::AppBannerPromptReply::NONE
+               : mojom::AppBannerPromptReply::CANCEL;
 }
 
 }  // namespace blink