Convert app banners to use Mojo.

third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BeforeInstallPromptEvent_h
 #define BeforeInstallPromptEvent_h
 
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptPromiseProperty.h"
+#include "core/frame/LocalFrame.h"
 #include "modules/EventModules.h"
 #include "modules/app_banner/AppBannerPromptResult.h"
-#include "platform/heap/Handle.h"
+#include "mojo/public/cpp/bindings/binding.h"
+#include "mojo/public/cpp/system/message_pipe.h"
+#include "public/platform/modules/app_banner/app_banner.mojom-blink.h"
+#include <utility>
 
 namespace blink {
 
 class BeforeInstallPromptEvent;
 class BeforeInstallPromptEventInit;
-class WebAppBannerClient;
 
 using UserChoiceProperty =
     ScriptPromiseProperty<Member<BeforeInstallPromptEvent>,
                           Member<AppBannerPromptResult>,
                           ToV8UndefinedGenerator>;
 
-class BeforeInstallPromptEvent final : public Event {
+class BeforeInstallPromptEvent final : public Event,
+                                       public mojom::blink::AppBannerEvent {
   DEFINE_WRAPPERTYPEINFO();
+  USING_PRE_FINALIZER(BeforeInstallPromptEvent, dispose);

[haraken, 2016/10/07 07:09:40]

The reason we need to add the pre-finalizer is that mojo::Binding holds a raw
pointer to BeforeInstallPromptEvent. It's a bit unfortunate that we have to add
a pre-finalizer for all GCed objects that have mojo::Binding. Is there any
option to make mojo::Binding hold WeakPersistent instead of a raw poniter? Then
we can remove the pre-finalizer.

[dominickn, 2016/10/13 00:18:15]

I believe this has landed now.

[dominickn, 2016/10/17 05:38:45]

Follow up: we have both an InterfacePtr and a binding to dispose of here. The
StructTraits option with rockot added handles the latter case, but we still need
to unbind the InterfacePtr. Leaving the dispose() here until we have the right
support.

 
  public:
   ~BeforeInstallPromptEvent() override;
 
-  static BeforeInstallPromptEvent* create(const AtomicString& name,
-                                          ExecutionContext* executionContext,
-                                          const Vector<String>& platforms,
-                                          int requestId,
-                                          WebAppBannerClient* client) {
-    return new BeforeInstallPromptEvent(name, executionContext, platforms,
-                                        requestId, client);
+  static BeforeInstallPromptEvent* create(
+      const AtomicString& name,
+      LocalFrame* frame,

[dcheng, 2016/10/07 07:03:16]

Nit: LocalFrame, as |frame| can't be null here.

[dominickn, 2016/10/13 00:18:15]

Do you mean LocalFrame&?

+      mojo::ScopedMessagePipeHandle serviceHandle,
+      mojo::ScopedMessagePipeHandle eventHandle,
+      const Vector<String>& platforms) {
+    return new BeforeInstallPromptEvent(name, frame, std::move(serviceHandle),
+                                        std::move(eventHandle), platforms);
   }
 
   static BeforeInstallPromptEvent* create(
       const AtomicString& name,
       const BeforeInstallPromptEventInit& init) {
     return new BeforeInstallPromptEvent(name, init);
   }
 
+  void dispose();
+
   Vector<String> platforms() const;
   ScriptPromise userChoice(ScriptState*);
   ScriptPromise prompt(ScriptState*);
 
   const AtomicString& interfaceName() const override;
   void preventDefault() override;
 
   DECLARE_VIRTUAL_TRACE();
 
  private:
   BeforeInstallPromptEvent(const AtomicString& name,
-                           ExecutionContext*,
-                           const Vector<String>& platforms,
-                           int requestId,
-                           WebAppBannerClient*);
+                           LocalFrame*,
+                           mojo::ScopedMessagePipeHandle serviceHandle,
+                           mojo::ScopedMessagePipeHandle eventHandle,
+                           const Vector<String>& platforms);
   BeforeInstallPromptEvent(const AtomicString& name,
                            const BeforeInstallPromptEventInit&);
 
+  // mojom::blink::AppBannerEvent methods:
+  void BannerAccepted(const WTF::String& platform) override;
+  void BannerDismissed() override;
+
+  mojom::blink::AppBannerServicePtr m_bannerService;
+  mojo::Binding<mojom::blink::AppBannerEvent> m_binding;

[esprehn, 2016/10/07 00:39:52]

What is a Binding vs a ServicePtr? Why do we need one?

[dcheng, 2016/10/07 07:03:16]

ServicePtr is an InterfacePtr and manages a message pipe to talk to a remote
object.

Binding manages the other end of a message pipe, so other things can talk to
this object remotely.

[dominickn, 2016/10/17 05:38:45]

As dcheng said, we need both of these here so that a) the AppBannerService can
talk to this object, and b) we can talk to the AppBannerService.

   Vector<String> m_platforms;
-
-  int m_requestId;
-  WebAppBannerClient* m_client;
   Member<UserChoiceProperty> m_userChoice;
-  bool m_registered;
+  bool m_promptCalled;
 };
 
 DEFINE_TYPE_CASTS(BeforeInstallPromptEvent,
                   Event,
                   event,
                   event->interfaceName() ==
                       EventNames::BeforeInstallPromptEvent,
                   event.interfaceName() ==
                       EventNames::BeforeInstallPromptEvent);
 
 }  // namespace blink
 
 #endif  // BeforeInstallPromptEvent_h