Convert app banners to use Mojo.

chrome/browser/banners/app_banner_manager_desktop.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/banners/app_banner_manager_desktop.h"
 
 #include "base/command_line.h"
-#include "base/strings/string_number_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/banners/app_banner_infobar_delegate_desktop.h"
 #include "chrome/browser/banners/app_banner_metrics.h"
 #include "chrome/browser/banners/app_banner_settings_helper.h"
 #include "chrome/browser/extensions/bookmark_app_helper.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_switches.h"
-#include "chrome/common/render_messages.h"
 #include "chrome/common/web_application_info.h"
-#include "content/public/browser/render_frame_host.h"
 #include "extensions/common/constants.h"
 
 DEFINE_WEB_CONTENTS_USER_DATA_KEY(banners::AppBannerManagerDesktop);
 
 namespace banners {
 
 bool AppBannerManagerDesktop::IsEnabled() {
 #if defined(OS_CHROMEOS)
   return !base::CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kDisableAddToShelf);
 #else
   return base::CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kEnableAddToShelf);
 #endif
 }
 
 AppBannerManagerDesktop::AppBannerManagerDesktop(
     content::WebContents* web_contents)
     : AppBannerManager(web_contents) { }
 
 AppBannerManagerDesktop::~AppBannerManagerDesktop() { }
 
 void AppBannerManagerDesktop::DidFinishCreatingBookmarkApp(
     const extensions::Extension* extension,
     const WebApplicationInfo& web_app_info) {
   content::WebContents* contents = web_contents();
   if (contents) {
     // A null extension pointer indicates that the bookmark app install was
-    // not successful.
+    // not successful. Call Stop() to terminate the flow. Don't record a dismiss
+    // metric here because the banner isn't necessarily dismissed.

[benwells, 2016/10/12 03:00:17]

Is this an orthogonal fix?

[dominickn, 2016/10/13 00:18:15]

The Stop() or the no dismiss? The Stop() fix is sort of orthogonal. It's because
the user could accept the banner, but hit Cancel on the bookmark app install
dialog. That will call to here with |extension| = nullptr, and in that case we
should clear out the current state. It's less important now that
AppBannerManager::binding_ is reset every time a new request starts, but it's
good for cleanliness.

The no dismiss is orthogonal and aligns desktop with Android.

     if (extension == nullptr) {
-      contents->GetMainFrame()->Send(new ChromeViewMsg_AppBannerDismissed(
-          contents->GetMainFrame()->GetRoutingID(), event_request_id()));
-
-      AppBannerSettingsHelper::RecordBannerDismissEvent(
-          contents, GetAppIdentifier(), AppBannerSettingsHelper::WEB);
+      Stop();
     } else {
-      contents->GetMainFrame()->Send(new ChromeViewMsg_AppBannerAccepted(
-          contents->GetMainFrame()->GetRoutingID(), event_request_id(),
-          GetBannerType()));
+      SendBannerAccepted(event_request_id());
 
       AppBannerSettingsHelper::RecordBannerInstallEvent(
           contents, GetAppIdentifier(), AppBannerSettingsHelper::WEB);
     }
   }
 }
 
 bool AppBannerManagerDesktop::IsWebAppInstalled(
     content::BrowserContext* browser_context,
     const GURL& start_url) {
@@ skipping 44 matching lines @@
     double score) {
   // Explicitly forbid banners from triggering on navigation unless this is
   // enabled.
   if (!IsEnabled())
     return;
 
   AppBannerManager::OnEngagementIncreased(web_contents, url, score);
 }
 
 }  // namespace banners