Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2393483002: Revert of VideoCapture: migrate VideoCapture renderer-->host messages to mojo, part 1 (Closed)

Created:
4 years, 2 months ago by mcasas
Modified:
4 years, 2 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of VideoCapture: migrate VideoCapture renderer-->host messages to mojo, part 1 (patchset #1 id:20001 of https://codereview.chromium.org/2384843002/ ) Reason for revert: Ouch! Messages are called Stop, etc but the mojom calls them StopCapture ! ==> the new messages are not being called :( Reverting to reland soon. Original issue's description: > VideoCapture: migrate VideoCapture renderer-->host messages to mojo, part 1 > > This CL migrates the easy-to-migrate video_capture_messages from > IPC to mojom. "Easy" refers to those messages whose data types are > readily available. > > BUG=651897 > TEST=./out/gn/content_unittests --gtest_filter=*VideoCapture*, > content_browsertests and video capture working as before. > > Committed: https://crrev.com/a2fc9a109f9280ca953e18a5f82c253ded6ddc26 > Cr-Commit-Position: refs/heads/master@{#422534} TBR=rockot@chromium.org,tibell@chromium.org,chfremer@chromium.org,tsepez@chromium.org,avi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=651897 Committed: https://crrev.com/6504ef716dbf9d2bf75689960ebccf3160b8a676 Cr-Commit-Position: refs/heads/master@{#422643}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -143 lines) Patch
M content/browser/renderer_host/media/video_capture_host.h View 5 chunks +34 lines, -18 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host.cc View 17 chunks +106 lines, -97 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/media/video_capture_messages.h View 1 chunk +1 line, -1 line 0 comments Download
D content/common/video_capture.mojom View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mcasas
Created Revert of VideoCapture: migrate VideoCapture renderer-->host messages to mojo, part 1
4 years, 2 months ago (2016-10-04 00:54:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393483002/1
4 years, 2 months ago (2016-10-04 00:55:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 00:56:05 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 00:57:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6504ef716dbf9d2bf75689960ebccf3160b8a676
Cr-Commit-Position: refs/heads/master@{#422643}

Powered by Google App Engine
This is Rietveld 408576698