Plumb use_system_xcode through native client.

Plumb use_system_xcode through native client.

NOTRY=true
BUG=chromium:651267
Committed: https://chromium.googlesource.com/native_client/src/native_client/+/cb2b66010be5078b3c533be58727c7f474cfd20c

[erikchen, 2016-10-04 00:20:52]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 00:21:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 00:21:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 00:21:01]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-nacl-committers".
Note that this has nothing to do with OWNERS files.

[erikchen, 2016-10-04 00:29:49]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 00:30:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 00:30:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 00:30:02]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-nacl-committers".
Note that this has nothing to do with OWNERS files.

[erikchen, 2016-10-04 00:31:40]

Description was changed from

==========
Plumb use_system_xcode through native client.

BUG=651267
==========

to

==========
Plumb use_system_xcode through native client.

BUG=chromium:651267
==========

[erikchen, 2016-10-04 00:37:05]

erikchen@chromium.org changed reviewers:
+ dpranke@chromium.org, justincohen@chromium.org, thakis@chromium.org

[erikchen, 2016-10-04 00:37:05]

dpranke, thakis: Please review.

[Dirk Pranke, 2016-10-04 20:26:49]

lgtm , though this might need to be updated if the dependent CL in //build is
updated per me comments in https://codereview.chromium.org/2388063003/ .

[Nico, 2016-10-04 20:35:22]

lgtm

[erikchen, 2016-10-06 17:17:00]

erikchen@chromium.org changed reviewers:
+ mseaborn@chromium.org

[erikchen, 2016-10-06 17:17:01]

mseaborn: Please review.

[Mark Seaborn, 2016-10-06 18:27:56]

LGTM

https://codereview.chromium.org/2393473002/diff/1/src/trusted/service_runtime...
File src/trusted/service_runtime/osx/run_mig.py (right):

https://codereview.chromium.org/2393473002/diff/1/src/trusted/service_runtime...
src/trusted/service_runtime/osx/run_mig.py:92: os.environ['DEVELOPER_DIR'] =
sys.argv[4]
Should be "args[3]" for consistency, rather than using sys.argv

[erikchen, 2016-10-06 20:46:22]

https://codereview.chromium.org/2393473002/diff/1/src/trusted/service_runtime...
File src/trusted/service_runtime/osx/run_mig.py (right):

https://codereview.chromium.org/2393473002/diff/1/src/trusted/service_runtime...
src/trusted/service_runtime/osx/run_mig.py:92: os.environ['DEVELOPER_DIR'] =
sys.argv[4]
On 2016/10/06 18:27:56, Mark Seaborn wrote:
> Should be "args[3]" for consistency, rather than using sys.argv

Done.

[erikchen, 2016-10-06 20:46:26]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-10-06 20:46:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
mseaborn@chromium.org, dpranke@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2393473002/#ps20001
(title: "Fix off by one erors.")

[commit-bot: I haz the power, 2016-10-06 20:46:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 20:49:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 20:49:18]

Try jobs failed on following builders:
  nacl-mac_glibc_dbg on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac_glibc_dbg/builds...)
  nacl-mac_glibc_opt on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac_glibc_opt/builds...)
  nacl-mac_newlib_dbg on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac_newlib_dbg/build...)

[erikchen, 2016-10-06 21:09:16]

On 2016/10/06 20:49:18, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   nacl-mac_glibc_dbg on master.tryserver.nacl (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac_glibc_dbg/builds...)
>   nacl-mac_glibc_opt on master.tryserver.nacl (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac_glibc_opt/builds...)
>   nacl-mac_newlib_dbg on master.tryserver.nacl (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac_newlib_dbg/build...)

ERROR at //native_client/src/trusted/service_runtime/BUILD.gn:330:10: Undefined
identifier
@@@STEP_LINK@stdout-->stdio@https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.nacl%2Fnacl-mac_newlib_opt%2F477%2F%2B%2Frecipes%2Fsteps%2Fgn_compile_32%2F0%2Fstdout@@@
    if (!use_system_xcode) {
         ^---------------
See //native_client/src/BUILD.gn:18:5: which caused the file to be included.
    "//native_client/src/trusted/service_runtime:env_cleanser",
    ^---------------------------------------------------------
Command return code: 1

Hm. I would have expected this to fail at
import("//build/toolchain/toolchain.gni"). We can probably use the
build_overrides approach to get the desired behavior...

[Roland McGrath, 2016-10-06 21:17:03]

On 2016/10/06 21:09:16, erikchen wrote:
> On 2016/10/06 20:49:18, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   nacl-mac_glibc_dbg on master.tryserver.nacl (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac_glibc_dbg/builds...)
> >   nacl-mac_glibc_opt on master.tryserver.nacl (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac_glibc_opt/builds...)
> >   nacl-mac_newlib_dbg on master.tryserver.nacl (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac_newlib_dbg/build...)
> 
> ERROR at //native_client/src/trusted/service_runtime/BUILD.gn:330:10:
Undefined
> identifier
>
@@@STEP_LINK@stdout-->stdio@https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.nacl%2Fnacl-mac_newlib_opt%2F477%2F%2B%2Frecipes%2Fsteps%2Fgn_compile_32%2F0%2Fstdout@@@
>     if (!use_system_xcode) {
>          ^---------------
> See //native_client/src/BUILD.gn:18:5: which caused the file to be included.
>     "//native_client/src/trusted/service_runtime:env_cleanser",
>     ^---------------------------------------------------------
> Command return code: 1
> 
> Hm. I would have expected this to fail at
> import("//build/toolchain/toolchain.gni"). We can probably use the
> build_overrides approach to get the desired behavior...

You need native_client/DEPS to update its references to the chrome repo before
you land this, so the bots are using chromium/src/build versions new enough to
work with your changes.  AFAIK that roll is still not adequately automated, so
perhaps ask someone on the nacl team (via bradnelson@) to do it for you first.

[erikchen, 2016-10-07 17:59:24]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-10-07 17:59:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
mseaborn@chromium.org, dpranke@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2393473002/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-10-07 17:59:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 18:02:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 18:02:27]

Try jobs failed on following builders:
  nacl-mac_glibc_dbg on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac_glibc_dbg/builds...)
  nacl-mac_newlib_dbg on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac_newlib_dbg/build...)
  nacl-mac_newlib_opt on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac_newlib_opt/build...)

[erikchen, 2016-10-12 23:32:44]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-10-12 23:32:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
mseaborn@chromium.org, dpranke@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2393473002/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-10-12 23:32:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikchen, 2016-10-13 00:15:56]

The CQ bit was unchecked by erikchen@chromium.org

[erikchen, 2016-10-13 00:16:50]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-10-13 00:16:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
mseaborn@chromium.org, dpranke@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2393473002/#ps80001
(title: "Remove print statement.")

[commit-bot: I haz the power, 2016-10-13 00:17:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 02:17:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 02:17:37]

Try jobs failed on following builders:
  nacl-win64_glibc_opt on master.tryserver.nacl (JOB_TIMED_OUT, no build URL)
  nacl-win64_newlib_dbg on master.tryserver.nacl (JOB_TIMED_OUT, no build URL)
  nacl-win64_newlib_opt on master.tryserver.nacl (JOB_TIMED_OUT, no build URL)
  nacl-win7_64_arm_newlib_opt on master.tryserver.nacl (JOB_TIMED_OUT, no build
URL)
  nacl-win7_64_newlib_opt_pnacl on master.tryserver.nacl (JOB_TIMED_OUT, no
build URL)

[erikchen, 2016-10-13 19:42:05]

"""
Error: Command 'git remote --verbose update' returned non-zero exit status 1 in
/b/slave.DEPS
error: cannot open .git/FETCH_HEAD: Read-only file system
"""

Do these bots need to be kicked? Removed?

[erikchen, 2016-10-13 20:23:02]

On 2016/10/13 19:42:05, erikchen wrote:
> """
> Error: Command 'git remote --verbose update' returned non-zero exit status 1
in
> /b/slave.DEPS
> error: cannot open .git/FETCH_HEAD: Read-only file system
> """
> 
> Do these bots need to be kicked? Removed?

Looks like other people are just manually landing CLs:
https://codereview.chromium.org/2410163005/

[Mark Seaborn, 2016-10-13 20:24:50]

On 13 October 2016 at 13:23, <erikchen@chromium.org> wrote:

> On 2016/10/13 19:42:05, erikchen wrote:
> > """
> > Error: Command 'git remote --verbose update' returned non-zero exit
> status 1
> in
> > /b/slave.DEPS
> > error: cannot open .git/FETCH_HEAD: Read-only file system
> > """
> >
> > Do these bots need to be kicked? Removed?
>
> Looks like other people are just manually landing CLs:
> https://codereview.chromium.org/2410163005/
>

Hmm, well, they shouldn't be doing that...  Can you ask a Chrome Infra
trooper to fix the bot problem, please?  I think that involves filing a
trooper issue, but they deal with them fairly quickly.

Cheers,
Mark

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at https://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[bradnelson, 2016-10-13 20:58:22]

bradnelson@chromium.org changed reviewers:
+ bradnelson@chromium.org

[bradnelson, 2016-10-13 20:58:23]

https://codereview.chromium.org/2393473002/diff/80001/src/trusted/service_run...
File src/trusted/service_runtime/BUILD.gn (right):

https://codereview.chromium.org/2393473002/diff/80001/src/trusted/service_run...
src/trusted/service_runtime/BUILD.gn:331: args += [ hermetic_xcode_path]
spacing on the right is funny.

[erikchen, 2016-10-13 21:11:40]

https://codereview.chromium.org/2393473002/diff/80001/src/trusted/service_run...
File src/trusted/service_runtime/BUILD.gn (right):

https://codereview.chromium.org/2393473002/diff/80001/src/trusted/service_run...
src/trusted/service_runtime/BUILD.gn:331: args += [ hermetic_xcode_path]
On 2016/10/13 20:58:22, bradnelson wrote:
> spacing on the right is funny.

Done.

[bradnelson, 2016-10-13 21:18:46]

The CQ bit was checked by bradnelson@chromium.org

[bradnelson, 2016-10-13 21:18:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
mseaborn@chromium.org, dpranke@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2393473002/#ps100001
(title: "fix spacing.")

[commit-bot: I haz the power, 2016-10-13 21:18:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradnelson, 2016-10-13 21:19:02]

lgtm

[commit-bot: I haz the power, 2016-10-13 22:21:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 22:21:42]

Try jobs failed on following builders:
  nacl-precise_64-newlib-arm_qemu-pnacl on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-ar...)

[erikchen, 2016-10-13 23:26:10]

On 2016/10/13 22:21:42, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   nacl-precise_64-newlib-arm_qemu-pnacl on master.tryserver.nacl (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-ar...)

maybe a real error that wasn't caught before because bots weren't working?

"""


/usr/bin/python
/b/build/slave/nacl-precise_64-newlib-arm_qemu-pnacl/build/native_client/tools/command_tester.py
--name pnacl_newlib.run_platform_tests --time_warning 2 --time_error 20
--perf_env_description trusted_linux_arm --subarch 32 --arch arm --output_stamp
/b/build/slave/nacl-precise_64-newlib-arm_qemu-pnacl/build/native_client/scons-out/opt-linux-arm/test_results/port_test.out
/b/build/slave/nacl-precise_64-newlib-arm_qemu-pnacl/build/native_client/toolchain/linux_x86/arm_trusted/run_under_qemu_arm
/b/build/slave/nacl-precise_64-newlib-arm_qemu-pnacl/build/native_client/scons-out/opt-linux-arm/obj/src/shared/platform/port_test

ERROR: Command returned exit status -11 (0xfffffff5) but did not output an
intended_exit_status line to stderr - did it exit too early?
======================================================================
Stdout for pnacl_newlib.run_minidump_crash_in_lib_test:
======================================================================

======================================================================
Stderr for pnacl_newlib.run_minidump_crash_in_lib_test:
======================================================================
DEBUG MODE ENABLED (bypass acl)
PLATFORM QUALIFICATION DISABLED BY -Q - Native Client's sandbox will be
unreliable!
[19371,4051771392:15:06:01.781308] BYPASSING ALL ACL CHECKS
[19371,4051771392:15:06:01.802641] Native Client module will be loaded at base
address 0x0000000000000000
qemu: uncaught target signal 11 (Segmentation fault) - core dumped

[  FAILED  ] pnacl_newlib.run_minidump_crash_in_lib_test (180 ms)
"""

[erikchen, 2016-10-13 23:26:16]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-10-13 23:26:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradn, 2016-10-13 23:50:17]

Description was changed from

==========
Plumb use_system_xcode through native client.

BUG=chromium:651267
==========

to

==========
Plumb use_system_xcode through native client.


NOPRESUBMIT=true
BUG=chromium:651267
==========

[bradn, 2016-10-13 23:50:27]

Description was changed from

==========
Plumb use_system_xcode through native client.


NOPRESUBMIT=true
BUG=chromium:651267
==========

to

==========
Plumb use_system_xcode through native client.

NOPRESUBMIT=true
BUG=chromium:651267
==========

[bradn, 2016-10-13 23:50:34]

The CQ bit was unchecked by bradnelson@google.com

[bradn, 2016-10-13 23:50:38]

The CQ bit was checked by bradnelson@google.com

[commit-bot: I haz the power, 2016-10-13 23:50:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradn, 2016-10-13 23:55:04]

Description was changed from

==========
Plumb use_system_xcode through native client.

NOPRESUBMIT=true
BUG=chromium:651267
==========

to

==========
Plumb use_system_xcode through native client.

NOTRY=true
BUG=chromium:651267
==========

[commit-bot: I haz the power, 2016-10-13 23:57:56]

Description was changed from

==========
Plumb use_system_xcode through native client.

NOTRY=true
BUG=chromium:651267
==========

to

==========
Plumb use_system_xcode through native client.

NOTRY=true
BUG=chromium:651267

Committed:
https://chromium.googlesource.com/native_client/src/native_client/+/cb2b66010...
==========

[commit-bot: I haz the power, 2016-10-13 23:57:57]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/native_client/src/native_client/+/cb2b66010...