Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <lint> | 2 <lint> |
| 3 <!-- | 3 <!-- |
| 4 STOP! It looks like you want to suppress some lint errors: | 4 STOP! It looks like you want to suppress some lint errors: |
| 5 - Have you tried identifing the offending patch? | 5 - Have you tried identifing the offending patch? |
| 6 Ask the author for a fix and/or revert the patch. | 6 Ask the author for a fix and/or revert the patch. |
| 7 - It is preferred to add suppressions in the code instead of | 7 - It is preferred to add suppressions in the code instead of |
| 8 sweeping it under the rug here. See: | 8 sweeping it under the rug here. See: |
| 9 | 9 |
| 10 http://developer.android.com/tools/debugging/improving-w-lint.html | 10 http://developer.android.com/tools/debugging/improving-w-lint.html |
| (...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 283 <ignore regexp="android_webview/java/res/drawable-hdpi/ic_play_circle_outlin e_black_48dp.png"/> | 283 <ignore regexp="android_webview/java/res/drawable-hdpi/ic_play_circle_outlin e_black_48dp.png"/> |
| 284 <ignore regexp="android_webview/test/shell/res/raw/resource_file.html"/> | 284 <ignore regexp="android_webview/test/shell/res/raw/resource_file.html"/> |
| 285 <ignore regexp="android_webview/test/shell/res/raw/resource_icon.png"/> | 285 <ignore regexp="android_webview/test/shell/res/raw/resource_icon.png"/> |
| 286 <ignore regexp="android_webview/tools/automated_ui_tests/java/res/"/> | 286 <ignore regexp="android_webview/tools/automated_ui_tests/java/res/"/> |
| 287 <ignore regexp="blimp/client/app/android/java/res/drawable-hdpi/btn_menu.png "/> | 287 <ignore regexp="blimp/client/app/android/java/res/drawable-hdpi/btn_menu.png "/> |
| 288 <ignore regexp="blimp/client/app/android/java/res/drawable-hdpi/btn_reload.p ng"/> | 288 <ignore regexp="blimp/client/app/android/java/res/drawable-hdpi/btn_reload.p ng"/> |
| 289 <ignore regexp="blimp/client/app/android/java/res/drawable-hdpi/textbox.9.pn g"/> | 289 <ignore regexp="blimp/client/app/android/java/res/drawable-hdpi/textbox.9.pn g"/> |
| 290 <ignore regexp="blimp/client/app/android/java/res/drawable-hdpi/web_input_ba ckground.9.png"/> | 290 <ignore regexp="blimp/client/app/android/java/res/drawable-hdpi/web_input_ba ckground.9.png"/> |
| 291 <ignore regexp="blimp/client/app/android/java/res/layout/blimp_main.xml"/> | 291 <ignore regexp="blimp/client/app/android/java/res/layout/blimp_main.xml"/> |
| 292 <ignore regexp="blimp/client/app/android/java/res/layout/debug_stats_overlay .xml"/> | 292 <ignore regexp="blimp/client/app/android/java/res/layout/debug_stats_overlay .xml"/> |
| 293 <ignore regexp="blimp/client/app/android/java/res/drawable/dotted_line.xml" /> | |
|
mikecase (-- gone --)
2016/11/04 23:39:11
nit: alphabetize
| |
| 293 <ignore regexp="blimp/client/app/android/java/res/layout/text_input_popup.xm l"/> | 294 <ignore regexp="blimp/client/app/android/java/res/layout/text_input_popup.xm l"/> |
| 294 <ignore regexp="blimp/client/app/android/java/res/layout/toolbar_popup_item. xml"/> | 295 <ignore regexp="blimp/client/app/android/java/res/layout/toolbar_popup_item. xml"/> |
| 296 <ignore regexp="blimp/client/app/android/java/res/layout/web_input_bottom_pa nel.xml"/> | |
| 295 <ignore regexp="blimp/client/app/android/java/res/mipmap-hdpi/app_icon.png"/ > | 297 <ignore regexp="blimp/client/app/android/java/res/mipmap-hdpi/app_icon.png"/ > |
| 296 <ignore regexp="blimp/client/app/android/java/res/values/arrays.xml"/> | 298 <ignore regexp="blimp/client/app/android/java/res/values/arrays.xml"/> |
| 297 <ignore regexp="blimp/client/app/android/java/res/values/colors.xml"/> | 299 <ignore regexp="blimp/client/app/android/java/res/values/colors.xml"/> |
| 298 <ignore regexp="blimp/client/app/android/java/res/values/dimens.xml"/> | 300 <ignore regexp="blimp/client/app/android/java/res/values/dimens.xml"/> |
| 299 <ignore regexp="blimp/client/app/android/java/res/xml/about_blimp_preference s.xml"/> | 301 <ignore regexp="blimp/client/app/android/java/res/xml/about_blimp_preference s.xml"/> |
| 300 <ignore regexp="blimp/client/app/android/java/res/xml/blimp_preferences.xml" /> | 302 <ignore regexp="blimp/client/app/android/java/res/xml/blimp_preferences.xml" /> |
| 301 <ignore regexp="chrome/android/java/res/drawable-hdpi/account_management_inc ognito.png"/> | 303 <ignore regexp="chrome/android/java/res/drawable-hdpi/account_management_inc ognito.png"/> |
| 302 <ignore regexp="chrome/android/java/res/drawable-hdpi/amex_card.png"/> | 304 <ignore regexp="chrome/android/java/res/drawable-hdpi/amex_card.png"/> |
| 303 <ignore regexp="chrome/android/java/res/drawable-hdpi/bubble_white.9.png"/> | 305 <ignore regexp="chrome/android/java/res/drawable-hdpi/bubble_white.9.png"/> |
| 304 <ignore regexp="chrome/android/java/res/drawable-hdpi/cvc_icon.png"/> | 306 <ignore regexp="chrome/android/java/res/drawable-hdpi/cvc_icon.png"/> |
| (...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 385 </issue> | 387 </issue> |
| 386 <issue id="ViewConstructor" severity="ignore"/> | 388 <issue id="ViewConstructor" severity="ignore"/> |
| 387 <issue id="WrongCall" severity="ignore"/> | 389 <issue id="WrongCall" severity="ignore"/> |
| 388 <issue id="WrongConstant"> | 390 <issue id="WrongConstant"> |
| 389 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java"/> | 391 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java"/> |
| 390 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java"/> | 392 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java"/> |
| 391 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java"/> | 393 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java"/> |
| 392 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /ChildProcessConnectionImpl.java"/> | 394 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /ChildProcessConnectionImpl.java"/> |
| 393 </issue> | 395 </issue> |
| 394 </lint> | 396 </lint> |
| OLD | NEW |