Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: src/wasm/wasm-module.cc

Issue 2393443003: [wasm] explicitly mark off unlinked wasm module instances (Closed)
Patch Set: [wasm] reset owning instance explicitly Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/wasm/regression-02256.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-module.cc
diff --git a/src/wasm/wasm-module.cc b/src/wasm/wasm-module.cc
index dde1571194105b8b1c89960b8b081611e22ee789..a2c8ec6b1d666f72d243a19983957cd7626ac4d7 100644
--- a/src/wasm/wasm-module.cc
+++ b/src/wasm/wasm-module.cc
@@ -773,7 +773,6 @@ static void ResetCompiledModule(Isolate* isolate, JSObject* owner,
}
}
}
- compiled_module->reset_weak_owning_instance();
compiled_module->reset_heap();
}
@@ -831,6 +830,7 @@ static void InstanceFinalizer(const v8::WeakCallbackInfo<void>& data) {
}
}
}
+ compiled_module->reset_weak_owning_instance();
GlobalHandles::Destroy(reinterpret_cast<Object**>(p));
}
« no previous file with comments | « no previous file | test/mjsunit/regress/wasm/regression-02256.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698