Chromium Code Reviews Chromium Code Reviews
Issue 2393413003:
Allocator shim explanatory error message. (Closed)
| OLD | NEW |
|---|---|
| 1 // Copyright 2016 The Chromium Authors. All rights reserved. | 1 // Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifdef BASE_ALLOCATOR_ALLOCATOR_SHIM_OVERRIDE_GLIBC_WEAK_SYMBOLS_H_ | 5 #ifdef BASE_ALLOCATOR_ALLOCATOR_SHIM_OVERRIDE_GLIBC_WEAK_SYMBOLS_H_ |
| 6 #error This header is meant to be included only once by allocator_shim.cc | 6 #error This header is meant to be included only once by allocator_shim.cc |
| 7 #endif | 7 #endif |
| 8 #define BASE_ALLOCATOR_ALLOCATOR_SHIM_OVERRIDE_GLIBC_WEAK_SYMBOLS_H_ | 8 #define BASE_ALLOCATOR_ALLOCATOR_SHIM_OVERRIDE_GLIBC_WEAK_SYMBOLS_H_ |
| 9 | 9 |
| 10 // Alias the internal Glibc symbols to the shim entry points. | 10 // Alias the internal Glibc symbols to the shim entry points. |
| (...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 98 SHIM_ALWAYS_EXPORT void* __libc_pvalloc(size_t size) | 98 SHIM_ALWAYS_EXPORT void* __libc_pvalloc(size_t size) |
| 99 SHIM_ALIAS_SYMBOL(ShimPvalloc); | 99 SHIM_ALIAS_SYMBOL(ShimPvalloc); |
| 100 | 100 |
| 101 SHIM_ALWAYS_EXPORT int __posix_memalign(void** r, size_t a, size_t s) | 101 SHIM_ALWAYS_EXPORT int __posix_memalign(void** r, size_t a, size_t s) |
| 102 SHIM_ALIAS_SYMBOL(ShimPosixMemalign); | 102 SHIM_ALIAS_SYMBOL(ShimPosixMemalign); |
| 103 | 103 |
| 104 } // extern "C" | 104 } // extern "C" |
| 105 | 105 |
| 106 // Safety check. | 106 // Safety check. |
| 107 #if !defined(__GLIBC__) | 107 #if !defined(__GLIBC__) |
| 108 #error The current platform does not seem to use Glibc. | 108 #error The target platform does not seem to use Glibc and allocator shim \ |
| 109 has no idea how to support target's libc. Please disable this feature \ | |
|
Primiano Tucci (use gerrit)
2016/10/06 13:08:32
I'd keep it shorter and just say:
"The target plat
| |
| 110 setting 'use_experimental_allocator_shim=false' in GN args. Sorry. | |
| 109 #endif | 111 #endif |
| OLD | NEW |
