Issue 23934008: Fix heap verifier for partially constructed arrays when allocation folding is off.

Issue 23934008: Fix heap verifier for partially constructed arrays when allocation folding is off. (Closed)

Created:
7 years, 3 months ago by Hannes Payer (out of office)

Modified:
7 years, 3 months ago

Reviewers:
mvstanton, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix heap verifier for partially constructed arrays when allocation folding is off. BUG= R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16713

Patch Set 4 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -8 lines)			Patch
	M	src/objects-debug.cc	View	1 2 3	2 chunks	+10 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mvstanton

Can the if condition be reversed? https://codereview.chromium.org/23934008/diff/2001/src/objects-debug.cc File src/objects-debug.cc (right): https://codereview.chromium.org/23934008/diff/2001/src/objects-debug.cc#newcode337 src/objects-debug.cc:337: // allocation folding ...

7 years, 3 months ago (2013-09-13 09:57:13 UTC) #2

Hannes Payer (out of office)

https://codereview.chromium.org/23934008/diff/2001/src/objects-debug.cc File src/objects-debug.cc (right): https://codereview.chromium.org/23934008/diff/2001/src/objects-debug.cc#newcode337 src/objects-debug.cc:337: // allocation folding is turned off. The elements pointer ...

7 years, 3 months ago (2013-09-13 11:30:27 UTC) #3

Hannes Payer (out of office)

7 years, 3 months ago (2013-09-13 11:48:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r16713 (presubmit successful).

Expand Messages | Collapse Messages