Handle reading upper-case placeholders

pkg/intl/lib/src/intl_message.dart

Index: pkg/intl/lib/src/intl_message.dart
diff --git a/pkg/intl/lib/src/intl_message.dart b/pkg/intl/lib/src/intl_message.dart
index 0eb67b13846541ee944d4f52931c26a93d4f9e72..2fe5fd021de16a923d3f0dda53821454adf74903 100644
--- a/pkg/intl/lib/src/intl_message.dart
+++ b/pkg/intl/lib/src/intl_message.dart
@@ -239,18 +239,37 @@ class LiteralString extends Message {
  */
 class VariableSubstitution extends Message {
   VariableSubstitution(this._index, Message parent) : super(parent);
-  VariableSubstitution.named(this._variableName, Message parent)
-      : super(parent);
+
+  /**
+   * Create a substitution based on the name rather than the index. The name

[Emily Fortuna, 2013/09/12 00:52:19]

yay, comments!

+   * may have been used as all upper-case in the translation tool, so we
+   * save it separately and look it up case-insensitively once the parent
+   * (and its arguments) are definitely available.
+   */
+  VariableSubstitution.named(String name, Message parent)
+      : super(parent) {
+    _variableNameUpper = name.toUpperCase();
+  }
 
   /** The index in the list of parameters of the containing function. */
   int _index;
   int get index {
     if (_index != null) return _index;
     if (arguments.isEmpty) return null;
-    return _index = arguments.indexOf(_variableName);
+    // We may have been given an all-uppercase version of the name, so compare
+    // case-insensitive.
+    _index = arguments.map((x) => x.toUpperCase()).toList()
+        .indexOf(_variableNameUpper);
+    return _index;
   }
 
   /**
+   * The variable name we get from parsing. This may be an all uppercase version
+   * of the Dart argument name.
+   */
+  String _variableNameUpper;
+
+  /**
    * The name of the variable in the parameter list of the containing function.
    * Used when generating code for the interpolation.
    */