Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2393393004: Don't call the decomposed thing a "Cipher Suite". (Closed)

Created:
4 years, 2 months ago by davidben
Modified:
4 years, 2 months ago
Reviewers:
lgarron, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't call the decomposed thing a "Cipher Suite". This matches the obsolete/modern part of the security panel. A cipher suite is a particular thing in TLS and is not just the bulk cipher. Cipher is a more appropriately generic term for a decomposition we made up. BUG=none Committed: https://crrev.com/ed71983339f7fd59412bbc9ef1c1b1c2d62631e7 Cr-Commit-Position: refs/heads/master@{#423763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
davidben
"Bulk Cipher" is what the TLS 1.2 spec calls it. TLS 1.3 just says "AEAD" ...
4 years, 2 months ago (2016-10-06 20:20:00 UTC) #2
lgarron
On 2016/10/06 at 20:20:00, davidben wrote: > "Bulk Cipher" is what the TLS 1.2 spec ...
4 years, 2 months ago (2016-10-06 20:20:47 UTC) #3
davidben
+pfeldman for OWNERS
4 years, 2 months ago (2016-10-06 20:33:52 UTC) #5
pfeldman
lgtm
4 years, 2 months ago (2016-10-06 21:07:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393393004/1
4 years, 2 months ago (2016-10-06 21:42:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 00:41:24 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 00:42:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed71983339f7fd59412bbc9ef1c1b1c2d62631e7
Cr-Commit-Position: refs/heads/master@{#423763}

Powered by Google App Engine
This is Rietveld 408576698