Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 2393363003: Fix Heap.cpp dependencies. (Closed)

Created:
4 years, 2 months ago by davidben
Modified:
4 years, 2 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Heap.cpp dependencies. https://codereview.chromium.org/2084933002 added a dependency on RuntimeEnabledFeatures.h, but the target doesn't depend on the generated files. BUG=none Committed: https://crrev.com/a03f6977c4a5042b738a0edcccb897d54c99c5e3 Cr-Commit-Position: refs/heads/master@{#423781}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/platform/heap/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
davidben
4 years, 2 months ago (2016-10-06 22:42:39 UTC) #2
haraken
LGTM
4 years, 2 months ago (2016-10-06 23:27:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393363003/1
4 years, 2 months ago (2016-10-06 23:30:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 02:23:43 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 02:25:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a03f6977c4a5042b738a0edcccb897d54c99c5e3
Cr-Commit-Position: refs/heads/master@{#423781}

Powered by Google App Engine
This is Rietveld 408576698