Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2393353005: [NTP Snippets] Overwrite the title of the ARTICLES if provided by the server (Closed)

Created:
4 years, 2 months ago by Marc Treib
Modified:
4 years, 2 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Overwrite the title of the ARTICLES if provided by the server BUG=653808 Committed: https://crrev.com/1969bdf6b0ca964a667d73c92f8b38855f5723d5 Cr-Commit-Position: refs/heads/master@{#423853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -5 lines) Patch
M components/ntp_snippets/remote/ntp_snippets_service.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M components/ntp_snippets/remote/ntp_snippets_service_unittest.cc View 4 chunks +52 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Marc Treib
PTAL!
4 years, 2 months ago (2016-10-07 12:29:14 UTC) #4
Bernhard Bauer
lgtm
4 years, 2 months ago (2016-10-07 13:49:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393353005/1
4 years, 2 months ago (2016-10-07 14:23:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 14:28:34 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 14:30:21 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1969bdf6b0ca964a667d73c92f8b38855f5723d5
Cr-Commit-Position: refs/heads/master@{#423853}

Powered by Google App Engine
This is Rietveld 408576698