Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1732)

Issue 2393353004: Prune deprecated functions from TypingCommand (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune deprecated functions from TypingCommand BUG=648949, 651373 Committed: https://crrev.com/cf43a0661cc568c57f073904d76b989b363b23ea Cr-Commit-Position: refs/heads/master@{#423801}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 8 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Xiaocheng
PTAL. The deprecated functions can be removed from deleteKeyPressed and forwardDeleteKeyPressed because the layout has ...
4 years, 2 months ago (2016-10-07 05:07:31 UTC) #4
yosin_UTC9
lgtm
4 years, 2 months ago (2016-10-07 05:18:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393353004/1
4 years, 2 months ago (2016-10-07 05:19:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 05:37:06 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 05:38:54 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf43a0661cc568c57f073904d76b989b363b23ea
Cr-Commit-Position: refs/heads/master@{#423801}

Powered by Google App Engine
This is Rietveld 408576698