Split ExtensionTestObserver and move to //extensions.

chrome/browser/extensions/extension_browser_test_notification_observer.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_BROWSER_TEST_NOTIFICATION_OBSERVER_H_
+#define CHROME_BROWSER_EXTENSIONS_EXTENSION_BROWSER_TEST_NOTIFICATION_OBSERVER_H_
+
+#include <string>
+
+#include "base/callback.h"

[Devlin, 2016/10/06 15:52:16]

needed? (this and others; please trim)

[Rahul Chaturvedi, 2016/10/11 20:12:35]

Done.

+#include "base/compiler_specific.h"
+#include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
+#include "content/public/browser/notification_details.h"
+#include "content/public/browser/notification_observer.h"
+#include "content/public/browser/notification_registrar.h"
+#include "content/public/browser/notification_types.h"
+#include "extensions/test/extension_test_notification_observer.h"
+
+class Browser;
+
+namespace content {
+class BrowserContext;
+class WindowedNotificationObserver;
+}
+

[Devlin, 2016/10/06 15:52:17]

Can this file be in the extensions:: namespace?

[Rahul Chaturvedi, 2016/10/11 20:12:34]

I am not sure why this wasn't in the first place, but this is just moved code. I
would rather not change something major like the namespace it belongs in.

[Devlin, 2016/10/11 22:53:45]

Can you add a
// TODO(devlin): This should be in the extensions namespace.
?

[Rahul Chaturvedi, 2016/10/12 20:25:53]

Done.

+// Test helper class for observing extension-related events.
+class ExtensionBrowserTestNotificationObserver

[Devlin, 2016/10/06 15:52:16]

nit: The common idiom is to name chrome versions ChromeFoo (see e.g.
ExtensionsClient and ChromeExtensionsClient, etc).  So this should be
ChromeExtensionTestNotificationObserver.

[Rahul Chaturvedi, 2016/10/11 20:12:35]

Done.

+    : public ExtensionTestNotificationObserver,
+      public extensions::ExtensionActionAPI::Observer {
+ public:
+  explicit ExtensionBrowserTestNotificationObserver(Browser*);

[Devlin, 2016/10/06 15:52:17]

chrome style still requires variable naming in header files, afaik.

[Rahul Chaturvedi, 2016/10/11 20:12:34]

Done.

+  ~ExtensionBrowserTestNotificationObserver() override;
+
+  // Wait for the number of visible page actions to change to |count|.

[Devlin, 2016/10/06 15:52:16]

Function descriptions should be descriptive, not imperative.  (line 37 is right,
but the rest need to be updated)

[Rahul Chaturvedi, 2016/10/11 20:12:35]

Done.

+  bool WaitForPageActionVisibilityChangeTo(int count);
+
+  // Waits until an extension is loaded and all view have loaded.
+  void WaitForExtensionAndViewLoad();
+
+  // Wait for all extension views to load.
+  bool WaitForExtensionViewsToLoad();
+
+  // Wait for extension to be idle.
+  bool WaitForExtensionIdle(const std::string& extension_id);
+
+  // Wait for extension to be not idle.
+  bool WaitForExtensionNotIdle(const std::string& extension_id);
+
+ private:
+  content::BrowserContext* GetBrowserContext();
+
+  // extensions::ExtensionActionAPI::Observer:
+  void OnPageActionsUpdated(content::WebContents* contents) override;
+
+  Browser* browser_;

[Devlin, 2016/10/06 15:52:17]

DISALLOW_COPY_AND_ASSIGN

[Rahul Chaturvedi, 2016/10/11 20:12:35]

Done.

+};
+
+#endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_BROWSER_TEST_NOTIFICATION_OBSERVER_H_