Remove code that checks if MessagePumpForGpu was signaled.

Remove code that checks if MessagePumpForGpu was signaled.

This reverts https://codereview.chromium.org/2077613002/.

The check was supposed to tell us whether GPU process main
thread's message pump was signaled at the time of the hang.
In practice 100% of crash dumps had the negative result.
After some additional research I realized that that was
a false negative and that this check doesn't work as
expected with auto-reset events. I confirmed that an
auto-reset event gets promptly reset back to non-signaled
when it gets signaled as long as there is at least one
thread already waiting on it. That is the case even when
when the target thread is never scheduled to run. The
check would work with a manual-reset event but apparently
it is useless in the case of an auto-reset event.

BUG=620904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/9fc5e16ec88edd066a0725c80918f6001dd8620f
Cr-Commit-Position: refs/heads/master@{#424040}

[stanisc, 2016-10-05 23:10:05]

Description was changed from

==========
Remove the code that checks if MessagePumpForGpu was signaled. It doesn't work
as expected.

BUG=620904
==========

to

==========
Remove the code that checks if MessagePumpForGpu was signaled. It doesn't work
as expected.

BUG=620904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[stanisc, 2016-10-05 23:11:03]

The CQ bit was checked by stanisc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 23:11:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 00:51:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 00:51:47]

Dry run: This issue passed the CQ dry run.

[stanisc, 2016-10-06 20:26:01]

Description was changed from

==========
Remove the code that checks if MessagePumpForGpu was signaled. It doesn't work
as expected.

BUG=620904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove the code that checks if MessagePumpForGpu was signaled.

This reverts https://codereview.chromium.org/2077613002/.

The check was supposed to tell us whether GPU process main
thread's message pump was signaled at the time of the hang.
That was don't by persisting the message pump's event
state in the crash dump generated by GPU watchdog.
In practice 100% of crash dumps had the negative result.
After some additional research I realized that that was
a false negative and that this check doesn't work as
expected with auto-reset events. I confirmed that an
auto-reset event gets promptly reset back to non-signaled 
when it gets signaled as long as there is at least one
thread already waiting on it. That is the case even when
when the target thread is never scheduled to run. The
check would work with a manual-reset event but apparently 
it is useless in the case of an auto-reset event.

BUG=620904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[stanisc, 2016-10-06 20:28:09]

Description was changed from

==========
Remove the code that checks if MessagePumpForGpu was signaled.

This reverts https://codereview.chromium.org/2077613002/.

The check was supposed to tell us whether GPU process main
thread's message pump was signaled at the time of the hang.
That was don't by persisting the message pump's event
state in the crash dump generated by GPU watchdog.
In practice 100% of crash dumps had the negative result.
After some additional research I realized that that was
a false negative and that this check doesn't work as
expected with auto-reset events. I confirmed that an
auto-reset event gets promptly reset back to non-signaled 
when it gets signaled as long as there is at least one
thread already waiting on it. That is the case even when
when the target thread is never scheduled to run. The
check would work with a manual-reset event but apparently 
it is useless in the case of an auto-reset event.

BUG=620904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove the code that checks if MessagePumpForGpu was signaled.

This reverts https://codereview.chromium.org/2077613002/.

The check was supposed to tell us whether GPU process main
thread's message pump was signaled at the time of the hang.
In practice 100% of crash dumps had the negative result.
After some additional research I realized that that was
a false negative and that this check doesn't work as
expected with auto-reset events. I confirmed that an
auto-reset event gets promptly reset back to non-signaled 
when it gets signaled as long as there is at least one
thread already waiting on it. That is the case even when
when the target thread is never scheduled to run. The
check would work with a manual-reset event but apparently 
it is useless in the case of an auto-reset event.

BUG=620904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[stanisc, 2016-10-06 20:30:07]

Patchset #1 (id:1) has been deleted

[stanisc, 2016-10-06 20:31:11]

Description was changed from

==========
Remove the code that checks if MessagePumpForGpu was signaled.

This reverts https://codereview.chromium.org/2077613002/.

The check was supposed to tell us whether GPU process main
thread's message pump was signaled at the time of the hang.
In practice 100% of crash dumps had the negative result.
After some additional research I realized that that was
a false negative and that this check doesn't work as
expected with auto-reset events. I confirmed that an
auto-reset event gets promptly reset back to non-signaled 
when it gets signaled as long as there is at least one
thread already waiting on it. That is the case even when
when the target thread is never scheduled to run. The
check would work with a manual-reset event but apparently 
it is useless in the case of an auto-reset event.

BUG=620904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove code that checks if MessagePumpForGpu was signaled.

This reverts https://codereview.chromium.org/2077613002/.

The check was supposed to tell us whether GPU process main
thread's message pump was signaled at the time of the hang.
In practice 100% of crash dumps had the negative result.
After some additional research I realized that that was
a false negative and that this check doesn't work as
expected with auto-reset events. I confirmed that an
auto-reset event gets promptly reset back to non-signaled 
when it gets signaled as long as there is at least one
thread already waiting on it. That is the case even when
when the target thread is never scheduled to run. The
check would work with a manual-reset event but apparently 
it is useless in the case of an auto-reset event.

BUG=620904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[stanisc, 2016-10-07 18:40:22]

stanisc@chromium.org changed reviewers:
+ dcheng@chromium.org, kbr@chromium.org

[stanisc, 2016-10-07 18:40:23]

kbr@chromium.org: Please review changes in gpu/

dcheng@chromium.org: Please review changes in base/message_loop

[dcheng, 2016-10-07 18:50:15]

lgtm

[Ken Russell (switch to Gerrit), 2016-10-07 18:58:34]

gpu/ lgtm

[stanisc, 2016-10-07 20:11:45]

The CQ bit was checked by stanisc@chromium.org

[commit-bot: I haz the power, 2016-10-07 20:12:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 22:18:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 22:18:35]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[stanisc, 2016-10-08 01:52:14]

The CQ bit was checked by stanisc@chromium.org

[commit-bot: I haz the power, 2016-10-08 01:52:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-08 01:57:35]

Description was changed from

==========
Remove code that checks if MessagePumpForGpu was signaled.

This reverts https://codereview.chromium.org/2077613002/.

The check was supposed to tell us whether GPU process main
thread's message pump was signaled at the time of the hang.
In practice 100% of crash dumps had the negative result.
After some additional research I realized that that was
a false negative and that this check doesn't work as
expected with auto-reset events. I confirmed that an
auto-reset event gets promptly reset back to non-signaled 
when it gets signaled as long as there is at least one
thread already waiting on it. That is the case even when
when the target thread is never scheduled to run. The
check would work with a manual-reset event but apparently 
it is useless in the case of an auto-reset event.

BUG=620904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove code that checks if MessagePumpForGpu was signaled.

This reverts https://codereview.chromium.org/2077613002/.

The check was supposed to tell us whether GPU process main
thread's message pump was signaled at the time of the hang.
In practice 100% of crash dumps had the negative result.
After some additional research I realized that that was
a false negative and that this check doesn't work as
expected with auto-reset events. I confirmed that an
auto-reset event gets promptly reset back to non-signaled 
when it gets signaled as long as there is at least one
thread already waiting on it. That is the case even when
when the target thread is never scheduled to run. The
check would work with a manual-reset event but apparently 
it is useless in the case of an auto-reset event.

BUG=620904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-10-08 01:57:36]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-10-08 01:59:32]

Description was changed from

==========
Remove code that checks if MessagePumpForGpu was signaled.

This reverts https://codereview.chromium.org/2077613002/.

The check was supposed to tell us whether GPU process main
thread's message pump was signaled at the time of the hang.
In practice 100% of crash dumps had the negative result.
After some additional research I realized that that was
a false negative and that this check doesn't work as
expected with auto-reset events. I confirmed that an
auto-reset event gets promptly reset back to non-signaled 
when it gets signaled as long as there is at least one
thread already waiting on it. That is the case even when
when the target thread is never scheduled to run. The
check would work with a manual-reset event but apparently 
it is useless in the case of an auto-reset event.

BUG=620904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove code that checks if MessagePumpForGpu was signaled.

This reverts https://codereview.chromium.org/2077613002/.

The check was supposed to tell us whether GPU process main
thread's message pump was signaled at the time of the hang.
In practice 100% of crash dumps had the negative result.
After some additional research I realized that that was
a false negative and that this check doesn't work as
expected with auto-reset events. I confirmed that an
auto-reset event gets promptly reset back to non-signaled
when it gets signaled as long as there is at least one
thread already waiting on it. That is the case even when
when the target thread is never scheduled to run. The
check would work with a manual-reset event but apparently
it is useless in the case of an auto-reset event.

BUG=620904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/9fc5e16ec88edd066a0725c80918f6001dd8620f
Cr-Commit-Position: refs/heads/master@{#424040}
==========

[commit-bot: I haz the power, 2016-10-08 01:59:33]

Patchset 1 (id:??) landed as
https://crrev.com/9fc5e16ec88edd066a0725c80918f6001dd8620f
Cr-Commit-Position: refs/heads/master@{#424040}