Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 239333015: Disable strict aliasing when building v8 for NaCl. (Closed)

Created:
6 years, 8 months ago by Jarin
Modified:
6 years, 8 months ago
CC:
v8-dev, bradnelson
Visibility:
Public.

Description

This should make the NaCl build jobs green again. BUG= R=hpayer@chromium.org, jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20854

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Makefile.nacl View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jarin
6 years, 8 months ago (2014-04-17 13:08:40 UTC) #1
Jakob Kummerow
rubberstamp LGTM.
6 years, 8 months ago (2014-04-17 13:14:51 UTC) #2
Hannes Payer (out of office)
LGTM
6 years, 8 months ago (2014-04-17 14:13:35 UTC) #3
Jarin
Committed patchset #1 manually as r20854 (presubmit successful).
6 years, 8 months ago (2014-04-17 14:22:26 UTC) #4
bradn
6 years, 8 months ago (2014-04-18 19:43:40 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698