Issue 239333014: Don't clear map word when dominator and dominated HAllocate belong to the same basic block.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239333014: Don't clear map word when dominator and dominated HAllocate belong to the same basic block. (Closed)

Created:
6 years, 8 months ago by Hannes Payer (out of office)

Modified:
6 years, 8 months ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Don't clear map word when dominator and dominated HAllocate belong to the same basic block. BUG=

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	src/hydrogen-instructions.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/hydrogen-instructions.cc	View		2 chunks	+8 lines, -4 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

titzer

https://codereview.chromium.org/239333014/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/239333014/diff/1/src/hydrogen-instructions.cc#newcode3964 src/hydrogen-instructions.cc:3964: block()->block_id() != dominated->block()->block_id()) { I don't think this is ...

6 years, 8 months ago (2014-04-17 12:41:46 UTC) #2

good point, I am closing this cl

Expand Messages | Collapse Messages