Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 239333002: Fix artifacts in distance field rendering due to bilerp (Closed)

Created:
6 years, 8 months ago by jvanverth1
Modified:
6 years, 8 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix artifacts in distance field rendering due to bilerp Because we were using the full distance field glyph rect, there were cases when a neighboring texel might be set to full value (e.g. we might copy the glyph over old data after a purge). This was giving artifacts, and insetting the rect by 1 solves the problem. In doing this, I discovered that removing the extra 1 texel pad around the glyph meant to handle bilerp, and insetting by 2, works just as well and saves space in the glyph atlas. Committed: http://code.google.com/p/skia/source/detail?r=14203

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M src/core/SkDistanceFieldGen.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 3 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jvanverth1
6 years, 8 months ago (2014-04-15 15:44:20 UTC) #1
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 8 months ago (2014-04-15 16:10:43 UTC) #2
bsalomon
On 2014/04/15 15:44:20, JimVV wrote: lgtm
6 years, 8 months ago (2014-04-15 16:10:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/239333002/1
6 years, 8 months ago (2014-04-15 16:10:55 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 16:10:55 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-15 16:10:56 UTC) #6
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 8 months ago (2014-04-15 16:11:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/239333002/1
6 years, 8 months ago (2014-04-15 16:11:22 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 17:53:25 UTC) #9
Message was sent while issue was closed.
Change committed as 14203

Powered by Google App Engine
This is Rietveld 408576698