src/factory.cc - Issue 2393303002: [modules] Store Module metadata in per-Context EmbedderData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 2393303002: [modules] Store Module metadata in per-Context EmbedderData (Closed)

Patch Set: Rebased Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 1f2c868faa90d08badf33920297686493e14a1e0..7af897ec22e4b33d4ad39ab028adabd9e802d85c 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -1764,7 +1764,6 @@ Handle<Module> Factory::NewModule(Handle<SharedFunctionInfo> code) {

Handle<Module> module = Handle<Module>::cast(NewStruct(MODULE_TYPE));

module->set_code(*code);

- module->set_embedder_data(isolate()->heap()->undefined_value());

module->set_exports(*exports);

module->set_flags(0);

module->set_hash(isolate()->GenerateIdentityHash(Smi::kMaxValue));

« no previous file with comments | « src/d8.cc ('k') | src/objects.h » ('j') | no next file with comments »