Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: src/objects.h

Issue 2393303002: [modules] Store Module metadata in per-Context EmbedderData (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/d8.cc ('K') | « src/factory.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 8a20ef081d4eabb0eb1eac4e59fbc7d38aec2d19..0484fb8422a3c7135f6cee53ded3a4e854dd3a62 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -7901,9 +7901,6 @@ class Module : public Struct {
// Storage for [[Evaluated]]
DECL_INT_ACCESSORS(flags)
- // Embedder-specified data
- DECL_ACCESSORS(embedder_data, Object)
-
// Get the SharedFunctionInfo associated with the code.
inline SharedFunctionInfo* shared() const;
@@ -7918,8 +7915,7 @@ class Module : public Struct {
// otherwise.
static MUST_USE_RESULT bool Instantiate(Handle<Module> module,
v8::Local<v8::Context> context,
- v8::Module::ResolveCallback callback,
- v8::Local<v8::Value> callback_data);
+ v8::Module::ResolveCallback callback);
// Implementation of spec operation ModuleEvaluation.
static MUST_USE_RESULT MaybeHandle<Object> Evaluate(Handle<Module> module);
« src/d8.cc ('K') | « src/factory.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698