Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Unified Diff: src/objects.cc

Issue 2393303002: [modules] Store Module metadata in per-Context EmbedderData (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/d8.cc ('K') | « src/objects.h ('k') | src/objects-debug.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index e817e777f11669b4bdf7935708c4d216a6bbafad..c563c8d1cc8e7571f73e9ae46442c5dc890718c2 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -19812,8 +19812,7 @@ MaybeHandle<Cell> Module::ResolveExportUsingStarExports(
}
bool Module::Instantiate(Handle<Module> module, v8::Local<v8::Context> context,
- v8::Module::ResolveCallback callback,
- v8::Local<v8::Value> callback_data) {
+ v8::Module::ResolveCallback callback) {
// Already instantiated.
if (module->code()->IsJSFunction()) return true;
@@ -19859,7 +19858,7 @@ bool Module::Instantiate(Handle<Module> module, v8::Local<v8::Context> context,
// persist a module_map across multiple top-level module loads, as
// the current module is left in a "half-instantiated" state.
if (!callback(context, v8::Utils::ToLocal(specifier),
- v8::Utils::ToLocal(module), callback_data)
+ v8::Utils::ToLocal(module))
.ToLocal(&api_requested_module)) {
// TODO(adamk): Give this a better error message. But this is a
// misuse of the API anyway.
@@ -19868,7 +19867,7 @@ bool Module::Instantiate(Handle<Module> module, v8::Local<v8::Context> context,
}
Handle<Module> requested_module = Utils::OpenHandle(*api_requested_module);
module->requested_modules()->set(i, *requested_module);
- if (!Instantiate(requested_module, context, callback, callback_data)) {
+ if (!Instantiate(requested_module, context, callback)) {
return false;
}
}
« src/d8.cc ('K') | « src/objects.h ('k') | src/objects-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698