Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2393293002: Make clusterfuzz_archive include llvm-symbolizer and sancov. (Closed)

Created:
4 years, 2 months ago by Oliver Chang
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Make clusterfuzz_archive include llvm-symbolizer and sancov. BUG=636168 Committed: https://chromium.googlesource.com/chromium/tools/build/+/fcac5b2bfcde27d33f34960c44066b976ee2006e

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Total comments: 2

Patch Set 3 : nit #

Total comments: 2

Patch Set 4 : nit + more expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+849 lines, -0 lines) Patch
M scripts/slave/recipe_modules/archive/api.py View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/archive/example.expected/cf_archiving_component.json View 1 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/archive/example.expected/cf_archiving_component_svn_with_git.json View 1 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/archive/example.expected/cf_archiving_linux.json View 1 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/archive/example.expected/cf_archiving_mac.json View 1 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/archive/example.expected/cf_archiving_svn_no_git.json View 1 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/archive/example.expected/cf_archiving_svn_with_git.json View 1 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/archive/example.expected/cf_archiving_win.json View 1 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CFI_Linux_CF.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_lkgr_ASAN_Debug.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_lkgr_ASAN_Release.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_lkgr_ASAN_Release_Media.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_lkgr_ASan_Debug__32_bit_x86_with_V8_ARM_.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_lkgr_ASan_Release_Media__32_bit_x86_with_V8_ARM_.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_lkgr_ASan_Release__32_bit_x86_with_V8_ARM_.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_lkgr_ChromiumOS_ASAN_Release.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_lkgr_MSAN_Release__chained_origins_.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_lkgr_MSAN_Release__no_origins_.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_lkgr_Mac_ASAN_Debug.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_lkgr_Mac_ASAN_Release.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_lkgr_Mac_ASAN_Release_Media.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_lkgr_TSAN_Debug.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_lkgr_TSAN_Release.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_lkgr_UBSan_Release.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_lkgr_UBSan_vptr_Release.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_lkgr_Win_ASan_Release.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_lkgr_Win_ASan_Release_Coverage.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_lkgr_Win_ASan_Release_Media.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_lkgr_Win_SyzyASAN_LKGR.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Chromium_ASAN___debug.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Chromium_ASAN__symbolized_.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Chromium_Win_SyzyASAN.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_afl.expected/full_chromium_fyi_Afl_Upload_Linux_ASan.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_ASan.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_ASan_Debug.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_MSan.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_UBSan.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Mac_ASan.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN___debug_builder.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN_arm64___debug_builder.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN_no_inline___release_builder.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux_ASAN_arm___debug_builder.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux_ASAN_mipsel___debug_builder.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
Oliver Chang
ptal
4 years, 2 months ago (2016-10-05 21:08:36 UTC) #7
inferno
lgtm https://codereview.chromium.org/2393293002/diff/1/scripts/slave/recipe_modules/archive/api.py File scripts/slave/recipe_modules/archive/api.py (right): https://codereview.chromium.org/2393293002/diff/1/scripts/slave/recipe_modules/archive/api.py#newcode273 scripts/slave/recipe_modules/archive/api.py:273: llvm_tools_to_copy = ['sancov', 'llvm-symbolizer'] nit: alpha ordering. https://codereview.chromium.org/2393293002/diff/1/scripts/slave/recipe_modules/archive/api.py#newcode276 ...
4 years, 2 months ago (2016-10-05 22:16:38 UTC) #8
Oliver Chang
Nico, mind taking a look? https://codereview.chromium.org/2393293002/diff/1/scripts/slave/recipe_modules/archive/api.py File scripts/slave/recipe_modules/archive/api.py (right): https://codereview.chromium.org/2393293002/diff/1/scripts/slave/recipe_modules/archive/api.py#newcode273 scripts/slave/recipe_modules/archive/api.py:273: llvm_tools_to_copy = ['sancov', 'llvm-symbolizer'] ...
4 years, 2 months ago (2016-10-06 18:50:07 UTC) #9
Nico
oh sorry. lgtm. https://codereview.chromium.org/2393293002/diff/20001/scripts/slave/recipe_modules/archive/api.py File scripts/slave/recipe_modules/archive/api.py (right): https://codereview.chromium.org/2393293002/diff/20001/scripts/slave/recipe_modules/archive/api.py#newcode276 scripts/slave/recipe_modules/archive/api.py:276: ext = '' nit: This can ...
4 years, 2 months ago (2016-10-06 18:54:47 UTC) #10
Nico
ps: After this, we can remove https://cs.chromium.org/chromium/src/build/sanitizers/BUILD.gn?q=llvm-symbolizer+file:%5C.gn&sq=package:chromium&l=18&dr=C , yeah?
4 years, 2 months ago (2016-10-06 18:56:07 UTC) #11
Oliver Chang
Thanks! > ps: After this, we can remove > https://cs.chromium.org/chromium/src/build/sanitizers/BUILD.gn?q=llvm-symbolizer+file:%5C.gn&sq=package:chromium&l=18&dr=C > , yeah? Yes, I ...
4 years, 2 months ago (2016-10-06 19:01:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393293002/40001
4 years, 2 months ago (2016-10-06 19:04:05 UTC) #15
Nico
https://codereview.chromium.org/2393293002/diff/40001/scripts/slave/recipe_modules/archive/api.py File scripts/slave/recipe_modules/archive/api.py (right): https://codereview.chromium.org/2393293002/diff/40001/scripts/slave/recipe_modules/archive/api.py#newcode276 scripts/slave/recipe_modules/archive/api.py:276: ext = '.exe' if self.m.platform.name == 'win' else '' ...
4 years, 2 months ago (2016-10-06 19:08:41 UTC) #16
Oliver Chang
https://codereview.chromium.org/2393293002/diff/40001/scripts/slave/recipe_modules/archive/api.py File scripts/slave/recipe_modules/archive/api.py (right): https://codereview.chromium.org/2393293002/diff/40001/scripts/slave/recipe_modules/archive/api.py#newcode276 scripts/slave/recipe_modules/archive/api.py:276: ext = '.exe' if self.m.platform.name == 'win' else '' ...
4 years, 2 months ago (2016-10-06 19:11:58 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393293002/60001
4 years, 2 months ago (2016-10-06 19:12:12 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/tools/build/+/fcac5b2bfcde27d33f34960c44066b976ee2006e
4 years, 2 months ago (2016-10-06 19:16:18 UTC) #23
mmoroz
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/2400143002/ by mmoroz@chromium.org. ...
4 years, 2 months ago (2016-10-07 09:27:59 UTC) #24
Sébastien Marchand
4 years, 2 months ago (2016-10-07 16:34:29 UTC) #26
Message was sent while issue was closed. 
This is breaking the SyzyAsan builder:
https://build.chromium.org/p/chromium.lkgr/builders/Win%20SyzyASAN%20LKGR

Powered by Google App Engine
This is Rietveld 408576698