Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2393263002: Fix chromium perf fyi tester triggering (Closed)

Created:
4 years, 2 months ago by martiniss
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Fix chromium perf fyi tester triggering The parent mastername of fyi builders isn't set for chromium.perf.fyi, which means the builders which triggers these testers don't know what they're supposed to build. And none of this is in expectations anywhere :/ BUG=639530 Committed: https://chromium.googlesource.com/chromium/tools/build/+/7f513989283831ce65f29f73c874e65932168ef0

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 11 (5 generated)
martiniss
PTAL
4 years, 2 months ago (2016-10-05 20:06:41 UTC) #4
ghost stip (do not use)
lgtm https://codereview.chromium.org/2393263002/diff/1/scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py File scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py (right): https://codereview.chromium.org/2393263002/diff/1/scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py#newcode47 scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py:47: spec['parent_mastername'] = 'chromium.perf.fyi' apparently only chromium.perf sets parent_buildername
4 years, 2 months ago (2016-10-05 20:55:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393263002/1
4 years, 2 months ago (2016-10-05 20:57:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/7f513989283831ce65f29f73c874e65932168ef0
4 years, 2 months ago (2016-10-05 21:01:46 UTC) #9
dtu
Hm, I thought it defaults to the current master.
4 years, 2 months ago (2016-10-06 00:29:00 UTC) #10
martiniss
4 years, 2 months ago (2016-10-06 00:54:28 UTC) #11
Message was sent while issue was closed.
On 2016/10/06 at 00:29:00, dtu wrote:
> Hm, I thought it defaults to the current master.

Ah, no. It does.
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_...

Powered by Google App Engine
This is Rietveld 408576698