Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2393253003: fix other printf warning for SkBlendMode (Closed)

Created:
4 years, 2 months ago by reed1
Modified:
4 years, 2 months ago
Reviewers:
hcm, dogben
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/utils/SkDumpCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
reed1
seems safe to force-land (imho) to unblock google3...?
4 years, 2 months ago (2016-10-06 13:44:47 UTC) #5
reed1
https://sponge.corp.google.com/target?id=f7c7cd6d-89e5-421c-9614-abb3352fd1e2&target=//apps/cereal/sumer:sumer_test_driver
4 years, 2 months ago (2016-10-06 13:45:12 UTC) #6
reed1
n/m about "force-land" -- I thought the tree was closed, but it aint. Chrome does ...
4 years, 2 months ago (2016-10-06 13:48:22 UTC) #7
hcm
On 2016/10/06 13:45:12, reed1 wrote: > https://sponge.corp.google.com/target?id=f7c7cd6d-89e5-421c-9614-abb3352fd1e2&target=//apps/cereal/sumer:sumer_test_driver lgtm, tree is open just only dry runs ...
4 years, 2 months ago (2016-10-06 13:49:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393253003/1
4 years, 2 months ago (2016-10-06 14:13:46 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/b55ebf071dce33794f5518dcdc3a9af006285796
4 years, 2 months ago (2016-10-06 14:14:41 UTC) #14
dogben
4 years, 2 months ago (2016-10-09 23:58:50 UTC) #15
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698