Reflow comments in //third_party/WebKit/Sourcecore/editing/serializers

Reflow comments in //third_party/WebKit/Source/core/editing/serializers

BUG=563793
Committed: https://crrev.com/ee42b66bf9a0c37018e03a5eb53fba6f37dfc0c0
Cr-Commit-Position: refs/heads/master@{#423444}

[dcheng, 2016-10-05 23:42:02]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 23:42:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-10-05 23:43:25]

dcheng@chromium.org changed reviewers:
+ yutak@chromium.org

[dcheng, 2016-10-06 00:00:36]

Description was changed from

==========
Reflow comments in //third_party/WebKit/Sourcecore/editing/serializers

BUG=563793
==========

to

==========
Reflow comments in //third_party/WebKit/Source/core/editing/serializers

BUG=563793
==========

[commit-bot: I haz the power, 2016-10-06 02:43:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 02:43:24]

Dry run: This issue passed the CQ dry run.

[Nico, 2016-10-06 03:26:20]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-10-06 03:26:21]

lgtm

https://codereview.chromium.org/2393243003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.h
(right):

https://codereview.chromium.org/2393243003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.h:56: //
reason. See http://trac.webkit.org/changeset/32879. However, we cannot do
nit:s/reason/reasons/

https://codereview.chromium.org/2393243003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.h:57: // this
in a XML document because it does not have the entity reference
nit: s/in a/in an/

https://codereview.chromium.org/2393243003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.h:58: //
defined (see the bug 19215).
nit: s/the//

https://codereview.chromium.org/2393243003/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/editing/serializers/StyledMarkupAccumulator.cpp
(right):

https://codereview.chromium.org/2393243003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/serializers/StyledMarkupAccumulator.cpp:103:
// -webkit-text-decorations-in-effect
nit: .

https://codereview.chromium.org/2393243003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/serializers/StyledMarkupAccumulator.cpp:174:
// -webkit-text-decorations-in-effect
nit: .

https://codereview.chromium.org/2393243003/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp
(right):

https://codereview.chromium.org/2393243003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp:479:
// can change it's appearance.
nit: s/it's/its/

https://codereview.chromium.org/2393243003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp:480:
// Make sure spans are inline style in paste side e.g. span { display:
nit: merge with previous line?

[dcheng, 2016-10-06 03:59:23]

https://codereview.chromium.org/2393243003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.h
(right):

https://codereview.chromium.org/2393243003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.h:56: //
reason. See http://trac.webkit.org/changeset/32879. However, we cannot do
On 2016/10/06 03:26:21, Nico wrote:
> nit:s/reason/reasons/

Done.

https://codereview.chromium.org/2393243003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.h:57: // this
in a XML document because it does not have the entity reference
On 2016/10/06 03:26:21, Nico wrote:
> nit: s/in a/in an/

Done.

https://codereview.chromium.org/2393243003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.h:58: //
defined (see the bug 19215).
On 2016/10/06 03:26:21, Nico wrote:
> nit: s/the//

Done.

https://codereview.chromium.org/2393243003/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/editing/serializers/StyledMarkupAccumulator.cpp
(right):

https://codereview.chromium.org/2393243003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/serializers/StyledMarkupAccumulator.cpp:103:
// -webkit-text-decorations-in-effect
On 2016/10/06 03:26:21, Nico wrote:
> nit: .

Done.

https://codereview.chromium.org/2393243003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/serializers/StyledMarkupAccumulator.cpp:174:
// -webkit-text-decorations-in-effect
On 2016/10/06 03:26:21, Nico wrote:
> nit: .

Done.

https://codereview.chromium.org/2393243003/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp
(right):

https://codereview.chromium.org/2393243003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp:479:
// can change it's appearance.
On 2016/10/06 03:26:21, Nico wrote:
> nit: s/it's/its/

Done.

https://codereview.chromium.org/2393243003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp:480:
// Make sure spans are inline style in paste side e.g. span { display:
On 2016/10/06 03:26:21, Nico wrote:
> nit: merge with previous line?

As far as I can tell, this was a distinct FIXME:
https://chromium.googlesource.com/chromium/src/+/9740cdd6e97675f0174592f75838...
(see patchsets like
https://bugs.webkit.org/attachment.cgi?id=103144&action=prettypatch, for
example).

So that's why I opted not to fold this line in.

[dcheng, 2016-10-06 03:59:27]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-10-06 03:59:28]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2393243003/#ps20001
(title: "Address nits")

[commit-bot: I haz the power, 2016-10-06 03:59:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 05:36:42]

Description was changed from

==========
Reflow comments in //third_party/WebKit/Source/core/editing/serializers

BUG=563793
==========

to

==========
Reflow comments in //third_party/WebKit/Source/core/editing/serializers

BUG=563793
==========

[commit-bot: I haz the power, 2016-10-06 05:36:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-06 05:38:12]

Description was changed from

==========
Reflow comments in //third_party/WebKit/Source/core/editing/serializers

BUG=563793
==========

to

==========
Reflow comments in //third_party/WebKit/Source/core/editing/serializers

BUG=563793

Committed: https://crrev.com/ee42b66bf9a0c37018e03a5eb53fba6f37dfc0c0
Cr-Commit-Position: refs/heads/master@{#423444}
==========

[commit-bot: I haz the power, 2016-10-06 05:38:13]

Patchset 2 (id:??) landed as
https://crrev.com/ee42b66bf9a0c37018e03a5eb53fba6f37dfc0c0
Cr-Commit-Position: refs/heads/master@{#423444}