[modules] Add basic path normalization to d8's module loader

[modules] Add basic path normalization to d8's module loader

d8 now elides './' when constructing absolute paths.
'../' is still not normalized.

R=neis@chromium.org
BUG=v8:1569
Committed: https://crrev.com/3aeaf497818ba84bff5afae2e0f3935e6b85291c
Cr-Commit-Position: refs/heads/master@{#40057}

[neis, 2016-10-06 07:18:29]

lgtm

lgtm modulo comment and the request to include a test along the lines of a file
"junk" containing the following:

import {foo as goo} from "./junk";
export let foo = 0;
foo++;
assertSame(foo, goo);
assertEquals(1, goo);

https://codereview.chromium.org/2393243002/diff/1/src/d8.cc
File src/d8.cc (right):

https://codereview.chromium.org/2393243002/diff/1/src/d8.cc#newcode556
src/d8.cc:556: // Resolves path to an absolute path if necessary, and do some
s/do/does/

https://codereview.chromium.org/2393243002/diff/1/src/d8.cc#newcode571
src/d8.cc:571: std::replace(result.begin(), result.end(), '\\', '/');
Don't you want to do the replace before searching for /./ ?

[adamk, 2016-10-06 18:50:38]

https://codereview.chromium.org/2393243002/diff/1/src/d8.cc
File src/d8.cc (right):

https://codereview.chromium.org/2393243002/diff/1/src/d8.cc#newcode556
src/d8.cc:556: // Resolves path to an absolute path if necessary, and do some
On 2016/10/06 07:18:29, neis wrote:
> s/do/does/

Done.

https://codereview.chromium.org/2393243002/diff/1/src/d8.cc#newcode571
src/d8.cc:571: std::replace(result.begin(), result.end(), '\\', '/');
On 2016/10/06 07:18:29, neis wrote:
> Don't you want to do the replace before searching for /./ ?

Done.

[adamk, 2016-10-06 18:50:46]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-10-06 18:50:46]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org
Link to the patchset: https://codereview.chromium.org/2393243002/#ps20001
(title: "Review comments, add test")

[commit-bot: I haz the power, 2016-10-06 18:50:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 19:32:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-06 19:32:44]

Description was changed from

==========
[modules] Add basic path normalization to d8's module loader

d8 now elides './' when constructing absolute paths.
'../' is still not normalized.

R=neis@chromium.org
BUG=v8:1569
==========

to

==========
[modules] Add basic path normalization to d8's module loader

d8 now elides './' when constructing absolute paths.
'../' is still not normalized.

R=neis@chromium.org
BUG=v8:1569

Committed: https://crrev.com/3aeaf497818ba84bff5afae2e0f3935e6b85291c
Cr-Commit-Position: refs/heads/master@{#40057}
==========

[commit-bot: I haz the power, 2016-10-06 19:32:45]

Patchset 2 (id:??) landed as
https://crrev.com/3aeaf497818ba84bff5afae2e0f3935e6b85291c
Cr-Commit-Position: refs/heads/master@{#40057}