cc: Update scroll offset before property tree scrolling and animation.

cc/trees/tree_synchronizer_unittest.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/tree_synchronizer.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <set>
 #include <vector>
 
 #include "base/format_macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/stringprintf.h"
 #include "cc/layers/layer.h"
 #include "cc/layers/layer_impl.h"
 #include "cc/test/animation_test_common.h"
 #include "cc/test/fake_impl_task_runner_provider.h"
 #include "cc/test/fake_layer_tree_host.h"
 #include "cc/test/fake_rendering_stats_instrumentation.h"
 #include "cc/test/stub_layer_tree_host_single_thread_client.h"
 #include "cc/test/test_shared_bitmap_manager.h"
 #include "cc/test/test_task_graph_runner.h"
 #include "cc/trees/effect_node.h"
 #include "cc/trees/layer_tree_host_common.h"
 #include "cc/trees/single_thread_proxy.h"
 #include "cc/trees/task_runner_provider.h"
+#include "cc/trees/transform_node.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace cc {
 namespace {
 
 class MockLayerImpl : public LayerImpl {
  public:
   static std::unique_ptr<MockLayerImpl> Create(LayerTreeImpl* tree_impl,
                                                int layer_id) {
     return base::WrapUnique(new MockLayerImpl(tree_impl, layer_id));
@@ skipping 574 matching lines @@
   scroll_offset_map.erase(transient_scroll_layer->id());
   scroll_offset_map[scroll_layer->id()]->SetCurrent(gfx::ScrollOffset(20, 30));
   scroll_offset_map[scroll_layer->id()]->PullDeltaForMainThread();
   scroll_offset_map[scroll_layer->id()]->SetCurrent(gfx::ScrollOffset(40, 50));
   scroll_offset_map[scroll_layer->id()]->PushFromMainThread(
       gfx::ScrollOffset(100, 100));
   scroll_offset_map[scroll_layer->id()]->PushPendingToActive();
   EXPECT_TRUE(is_equal(scroll_offset_map, scroll_tree.scroll_offset_map()));
 }
 
+TEST_F(TreeSynchronizerTest,
+       SynchronizeScrollTreeScrollOffsetMapFromMainToActive) {
+  host_->InitializeSingleThreaded(&single_thread_client_,
+                                  base::ThreadTaskRunnerHandle::Get());
+  FakeLayerTreeHostImpl* host_impl = host_->host_impl();
+
+  scoped_refptr<Layer> layer_tree_root = Layer::Create();
+  scoped_refptr<Layer> scroll_clip_layer = Layer::Create();
+  scoped_refptr<Layer> scroll_layer = Layer::Create();
+
+  layer_tree_root->AddChild(scroll_clip_layer);
+  scroll_clip_layer->AddChild(scroll_layer);
+
+  scroll_layer->SetScrollClipLayerId(scroll_clip_layer->id());
+  scroll_layer->SetScrollOffset(gfx::ScrollOffset(10, 20));
+
+  host_->SetRootLayer(layer_tree_root);
+  host_->BuildPropertyTreesForTesting();
+  host_->FinishCommitOnImplThread(host_impl);
+
+  ExpectTreesAreIdentical(layer_tree_root.get(),
+                          host_impl->active_tree()->root_layer_for_testing(),
+                          host_impl->active_tree());
+
+  // After the initial commit, scroll_offset_map in scroll_tree is expected to
+  // have one entry for scroll_layer and one entry for transient_scroll_layer,
+  // the pending base and active base must be the same at this stage.
+  ScrollTree::ScrollOffsetMap scroll_offset_map;
+  scroll_offset_map[scroll_layer->id()] = new SyncedScrollOffset;
+  scroll_offset_map[scroll_layer->id()]->PushFromMainThread(
+      scroll_layer->scroll_offset());
+  scroll_offset_map[scroll_layer->id()]->PushPendingToActive();
+  EXPECT_TRUE(
+      is_equal(scroll_offset_map, host_impl->active_tree()
+                                      ->property_trees()
+                                      ->scroll_tree.scroll_offset_map()));
+
+  // When running Layout tests in single thread mode, it is possible that the
+  // scroll tree's scroll offset map got cleared between commits, as a new test
+  // is started after finishing the previous one.
+  host_->property_trees()->scroll_tree.scroll_offset_map().clear();
+  scroll_layer->SetScrollOffset(gfx::ScrollOffset(0, 0));
+
+  host_->BuildPropertyTreesForTesting();
+  host_->FinishCommitOnImplThread(host_impl);
+
+  scroll_offset_map[scroll_layer->id()]->PushFromMainThread(
+      gfx::ScrollOffset(0, 0));
+  scroll_offset_map[scroll_layer->id()]->PushPendingToActive();
+  EXPECT_TRUE(
+      is_equal(scroll_offset_map, host_impl->active_tree()
+                                      ->property_trees()
+                                      ->scroll_tree.scroll_offset_map()));
+  EXPECT_EQ(host_impl->active_tree()
+                ->property_trees()
+                ->transform_tree.Node(scroll_layer->transform_tree_index())
+                ->scroll_offset,
+            gfx::ScrollOffset(0, 0));
+}
+
 TEST_F(TreeSynchronizerTest, RefreshPropertyTreesCachedData) {
   host_->InitializeSingleThreaded(&single_thread_client_,
                                   base::ThreadTaskRunnerHandle::Get());
   LayerTreeSettings settings;
   FakeLayerTreeHostImplClient client;
   FakeImplTaskRunnerProvider task_runner_provider;
   FakeRenderingStatsInstrumentation stats_instrumentation;
   TestSharedBitmapManager shared_bitmap_manager;
   TestTaskGraphRunner task_graph_runner;
   FakeLayerTreeHostImpl* host_impl = host_->host_impl();
@@ skipping 28 matching lines @@
   host_->CommitAndCreatePendingTree();
   host_impl->ActivateSyncTree();
   EXPECT_EQ(
       CombinedAnimationScale(0.f, 0.f),
       host_impl->active_tree()->property_trees()->GetAnimationScales(
           transform_layer->transform_tree_index(), host_impl->active_tree()));
 }
 
 }  // namespace
 }  // namespace cc