Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2393193002: Revert of [interpreter] Add string type feedback to add (Closed)

Created:
4 years, 2 months ago by Leszek Swirski
Modified:
4 years, 2 months ago
Reviewers:
rmcilroy, mythria
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [interpreter] Add string type feedback to add (patchset #3 id:40001 of https://codereview.chromium.org/2392533002/ ) Reason for revert: Broke the tree again, for no obvious reason :/ Original issue's description: > [interpreter] Add string type feedback to add > > Adds string type feedback to Ignition's AddWithFeedback code stub, for now only > adding a special case for when both lhs and rhs are strings. This improves > octane's splay by >100%. > > BUG=v8:5400 > > Committed: https://crrev.com/fb4ae2239d37adaf0321165034050316914de708 > Committed: https://crrev.com/bf1a94f1b269914856a8c8763fd282367f066c67 > Cr-Original-Commit-Position: refs/heads/master@{#39987} > Cr-Commit-Position: refs/heads/master@{#39996} TBR=rmcilroy@chromium.org,mythria@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5400 Committed: https://crrev.com/99493fea6bb2fc73304f979486dac287392c18b7 Cr-Commit-Position: refs/heads/master@{#40000}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -69 lines) Patch
M src/code-stubs.cc View 5 chunks +7 lines, -34 lines 0 comments Download
M src/globals.h View 1 chunk +1 line, -8 lines 0 comments Download
M src/type-feedback-vector-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 6 chunks +12 lines, -25 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Leszek Swirski
Created Revert of [interpreter] Add string type feedback to add
4 years, 2 months ago (2016-10-05 15:26:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393193002/1
4 years, 2 months ago (2016-10-05 15:26:32 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-05 15:26:34 UTC) #5
rmcilroy
LGTM
4 years, 2 months ago (2016-10-05 15:33:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393193002/1
4 years, 2 months ago (2016-10-05 15:33:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 15:33:52 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/99493fea6bb2fc73304f979486dac287392c18b7 Cr-Commit-Position: refs/heads/master@{#40000}
4 years, 2 months ago (2016-10-05 15:34:23 UTC) #11
Michael Achenbach
4 years, 2 months ago (2016-10-05 18:06:17 UTC) #12
Message was sent while issue was closed.
On 2016/10/05 15:34:23, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/99493fea6bb2fc73304f979486dac287392c18b7
> Cr-Commit-Position: refs/heads/master@{#40000}

Eh. Guess it's unrelated. Will land a landmine later. Or you could add one on re
land. Just add a line to get_landmines.py

Powered by Google App Engine
This is Rietveld 408576698