Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2393183002: Revert of Add a clang-format exception to WebInputEvent::Modifiers. (Closed)

Created:
4 years, 2 months ago by estevenson
Modified:
4 years, 2 months ago
Reviewers:
Nico, dcheng
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a clang-format exception to WebInputEvent::Modifiers. (patchset #1 id:1 of https://codereview.chromium.org/2378283006/ ) Reason for revert: crbug/652018 is fixed; build/android/gyp/java_cpp_enum.py handles multi-line enum entries so the clang-format exception is no longer necessary. Original issue's description: > Add a clang-format exception to WebInputEvent::Modifiers. > > build/android/gyp/java_cpp_enum.py gets confused when clang-format wraps > the excessively long line. > > BUG=652018 > R=thakis@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/b6ae86a409be490daa69803c62dcd0d6bee7b303 TBR=thakis@chromium.org,dcheng@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=652018 Committed: https://crrev.com/cc0da208fe58bbb9a4fa3290cdae739c2511ad1c Cr-Commit-Position: refs/heads/master@{#423326}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add trailing "," #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M third_party/WebKit/public/platform/WebInputEvent.h View 1 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
estevenson
Created Revert of Add a clang-format exception to WebInputEvent::Modifiers.
4 years, 2 months ago (2016-10-05 15:11:23 UTC) #1
Nico
lgtm, thanks!
4 years, 2 months ago (2016-10-05 15:12:57 UTC) #2
Nico
https://codereview.chromium.org/2393183002/diff/1/third_party/WebKit/public/platform/WebInputEvent.h File third_party/WebKit/public/platform/WebInputEvent.h (right): https://codereview.chromium.org/2393183002/diff/1/third_party/WebKit/public/platform/WebInputEvent.h#newcode197 third_party/WebKit/public/platform/WebInputEvent.h:197: SymbolKey | FnKey | AltGrKey | MetaKey | AltKey ...
4 years, 2 months ago (2016-10-05 15:13:42 UTC) #3
estevenson
https://codereview.chromium.org/2393183002/diff/1/third_party/WebKit/public/platform/WebInputEvent.h File third_party/WebKit/public/platform/WebInputEvent.h (right): https://codereview.chromium.org/2393183002/diff/1/third_party/WebKit/public/platform/WebInputEvent.h#newcode197 third_party/WebKit/public/platform/WebInputEvent.h:197: SymbolKey | FnKey | AltGrKey | MetaKey | AltKey ...
4 years, 2 months ago (2016-10-05 15:34:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393183002/40001
4 years, 2 months ago (2016-10-05 15:36:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/306041)
4 years, 2 months ago (2016-10-05 18:43:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393183002/40001
4 years, 2 months ago (2016-10-05 18:49:05 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-10-05 22:57:05 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 23:00:42 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cc0da208fe58bbb9a4fa3290cdae739c2511ad1c
Cr-Commit-Position: refs/heads/master@{#423326}

Powered by Google App Engine
This is Rietveld 408576698