third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp - Issue 2393133005: Call LocalDOMWindow::clearDocument when a frame gets detached

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

Issue 2393133005: Call LocalDOMWindow::clearDocument when a frame gets detached

Patch Set: temp Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

index 86f2a58cdd13d15cae46cec45c18279a660a36d9..6811a9b165354fd7c30dbc48ac8a21ffcb898b09 100644

--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

@@ -475,6 +475,7 @@ void LocalDOMWindow::frameDestroyed() {

for (const auto& domWindowProperty : m_properties)

domWindowProperty->frameDestroyed();

+ clearDocument();

resetLocation();

m_properties.clear();

removeAllEventListeners();