Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 2393133002: Prune deprecated editing functions from ApplyBlockElementCommand and its subclasses (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune deprecated editing functions from ApplyBlockElementCommand and its subclasses This patch prunes the following deprecated functions from ApplyBlockElementCommand and its subclasses by ensuring clean layout and valid arguments at each call site: - createVisiblePositionDeprecated - createVisibleSelectionDeprecated - VisibleSelection::visible{Start,End}Deprecated - nextPositionOfDeprecated - paragraph related deprecated functions BUG=647219, 651373 Committed: https://crrev.com/f68abcbb358214261742479653a6ef534b7837b0 Cr-Commit-Position: refs/heads/master@{#423395}

Patch Set 1 #

Patch Set 2 : Add a missing layout update call #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -88 lines) Patch
M third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp View 14 chunks +40 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp View 1 4 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp View 9 chunks +56 lines, -37 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-06 01:31:53 UTC) #12
yosin_UTC9
lgtm
4 years, 2 months ago (2016-10-06 02:06:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393133002/20001
4 years, 2 months ago (2016-10-06 02:07:27 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 02:14:16 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 02:16:34 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f68abcbb358214261742479653a6ef534b7837b0
Cr-Commit-Position: refs/heads/master@{#423395}

Powered by Google App Engine
This is Rietveld 408576698