Prune deprecated editing functions from ApplyBlockElementCommand and its subclasses

Prune deprecated editing functions from ApplyBlockElementCommand and its subclasses

This patch prunes the following deprecated functions from ApplyBlockElementCommand
and its subclasses by ensuring clean layout and valid arguments at each call site:
- createVisiblePositionDeprecated
- createVisibleSelectionDeprecated
- VisibleSelection::visible{Start,End}Deprecated
- nextPositionOfDeprecated
- paragraph related deprecated functions

BUG=647219, 651373
Committed: https://crrev.com/f68abcbb358214261742479653a6ef534b7837b0
Cr-Commit-Position: refs/heads/master@{#423395}

[Xiaocheng, 2016-10-05 08:32:24]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 08:32:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-10-05 08:38:51]

Description was changed from

==========
Pruned deprecated editing functions from ApplyBlockElementCommand and its
subclasses



BUG=647219,651373
==========

to

==========
Prune deprecated editing functions from ApplyBlockElementCommand and its
subclasses

This patch prunes the following deprecated functions from
ApplyBlockElementCommand
and its subclasses by ensuring clean layout and valid arguments at each call
site:
- createVisiblePositionDeprecated
- createVisibleSelectionDeprecated
- VisibleSelection::visible{Start,End}Deprecated
- {previous,next}PositionOfDeprecated
- paragraph related deprecated functions

BUG=647219,651373
==========

[Xiaocheng, 2016-10-05 08:39:34]

Description was changed from

==========
Prune deprecated editing functions from ApplyBlockElementCommand and its
subclasses

This patch prunes the following deprecated functions from
ApplyBlockElementCommand
and its subclasses by ensuring clean layout and valid arguments at each call
site:
- createVisiblePositionDeprecated
- createVisibleSelectionDeprecated
- VisibleSelection::visible{Start,End}Deprecated
- {previous,next}PositionOfDeprecated
- paragraph related deprecated functions

BUG=647219,651373
==========

to

==========
Prune deprecated editing functions from ApplyBlockElementCommand and its
subclasses

This patch prunes the following deprecated functions from
ApplyBlockElementCommand
and its subclasses by ensuring clean layout and valid arguments at each call
site:
- createVisiblePositionDeprecated
- createVisibleSelectionDeprecated
- VisibleSelection::visible{Start,End}Deprecated
- nextPositionOfDeprecated
- paragraph related deprecated functions

BUG=647219,651373
==========

[commit-bot: I haz the power, 2016-10-05 09:30:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 09:30:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xiaocheng, 2016-10-05 15:23:36]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 15:24:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 18:40:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 18:40:13]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-10-06 01:31:53]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-10-06 01:31:53]

PTAL.

[yosin_UTC9, 2016-10-06 02:06:48]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-10-06 02:06:48]

lgtm

[commit-bot: I haz the power, 2016-10-06 02:07:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 02:14:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-06 02:16:33]

Description was changed from

==========
Prune deprecated editing functions from ApplyBlockElementCommand and its
subclasses

This patch prunes the following deprecated functions from
ApplyBlockElementCommand
and its subclasses by ensuring clean layout and valid arguments at each call
site:
- createVisiblePositionDeprecated
- createVisibleSelectionDeprecated
- VisibleSelection::visible{Start,End}Deprecated
- nextPositionOfDeprecated
- paragraph related deprecated functions

BUG=647219,651373
==========

to

==========
Prune deprecated editing functions from ApplyBlockElementCommand and its
subclasses

This patch prunes the following deprecated functions from
ApplyBlockElementCommand
and its subclasses by ensuring clean layout and valid arguments at each call
site:
- createVisiblePositionDeprecated
- createVisibleSelectionDeprecated
- VisibleSelection::visible{Start,End}Deprecated
- nextPositionOfDeprecated
- paragraph related deprecated functions

BUG=647219,651373

Committed: https://crrev.com/f68abcbb358214261742479653a6ef534b7837b0
Cr-Commit-Position: refs/heads/master@{#423395}
==========

[commit-bot: I haz the power, 2016-10-06 02:16:34]

Patchset 2 (id:??) landed as
https://crrev.com/f68abcbb358214261742479653a6ef534b7837b0
Cr-Commit-Position: refs/heads/master@{#423395}