Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 239313004: EF_NUMPAD_KEY flag for ui::KeyEvent (Closed)

Created:
6 years, 8 months ago by kpschoedel
Modified:
6 years, 8 months ago
Reviewers:
sadrul, Daniel Erat
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

EF_NUMPAD_KEY flag for ui::KeyEvent Added a flag to distinguish between a KeyEvent that originates from a number pad key and one that does not, where the KeyboardCode is the same. For example, VKEY_LEFT can originate both from the cursor block and the number pad '4' key, and the latter will have the EF_NUMPAD_KEY flag set. This is needed to rewrite number pad events to number key events without affecting editing key events. BUG=354034 TEST=events_unittests EventsXTest.NumpadKeyEvents R=sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264257

Patch Set 1 #

Patch Set 2 : Fix unit_tests.EventRewriterTest.TestRewriteNumPadKeys* #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -26 lines) Patch
M chrome/browser/chromeos/events/event_rewriter_unittest.cc View 1 25 chunks +25 lines, -25 lines 0 comments Download
M ui/events/event_constants.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/events/x/events_x.cc View 3 chunks +7 lines, -1 line 0 comments Download
M ui/events/x/events_x_unittest.cc View 3 chunks +132 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
kpschoedel
6 years, 8 months ago (2014-04-15 17:05:02 UTC) #1
sadrul
lgtm
6 years, 8 months ago (2014-04-15 20:35:22 UTC) #2
sadrul
On 2014/04/15 20:35:22, sadrul wrote: > lgtm You probably want to change the CL title/description ...
6 years, 8 months ago (2014-04-15 20:36:03 UTC) #3
kpschoedel
The CQ bit was checked by kpschoedel@chromium.org
6 years, 8 months ago (2014-04-15 20:39:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/239313004/1
6 years, 8 months ago (2014-04-15 20:41:02 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 21:54:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-15 21:54:27 UTC) #7
kpschoedel
derat, PTAL @ chrome/browser/chromeos/events/event_rewriter_unittest.cc These tests check for an exact flag match and so need ...
6 years, 8 months ago (2014-04-16 15:48:39 UTC) #8
Daniel Erat
lgtm for c/b/chromeos
6 years, 8 months ago (2014-04-16 15:52:11 UTC) #9
kpschoedel
The CQ bit was checked by kpschoedel@chromium.org
6 years, 8 months ago (2014-04-16 15:55:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/239313004/20001
6 years, 8 months ago (2014-04-16 15:56:07 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 18:32:50 UTC) #12
Message was sent while issue was closed.
Change committed as 264257

Powered by Google App Engine
This is Rietveld 408576698