Harden runtime functions

Harden runtime functions

Part 1 of many.

R=dslomov@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20836

[Jakob Kummerow, 2014-04-15 15:27:31]

As discussed, this is my current work in progress. Any comments so far?

https://codereview.chromium.org/239313002/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/239313002/diff/1/src/runtime.cc#newcode565
src/runtime.cc:565: RUNTIME_ASSERT(literals_index >= 0 && literals_index <
literals->length());
Urgh. After rebasing, this doesn't compile any more. Will have to refactor this.

https://codereview.chromium.org/239313002/diff/1/src/runtime.cc#newcode862
src/runtime.cc:862: if (byteLength->IsSmi()) {
Come to think of it, we can probably just call NumberToSize(byteLength) here.

https://codereview.chromium.org/239313002/diff/1/src/runtime.cc#newcode902
src/runtime.cc:902: size_t start = NumberToSize(isolate, first);
As discussed, we'll want to return an exception rather than CHECK()ing in case
of failure.

[Jakob Kummerow, 2014-04-16 17:29:56]

https://codereview.chromium.org/239313002/diff/20001/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/239313002/diff/20001/src/runtime.cc#newcode1012
src/runtime.cc:1012: // TODO(jkummerow): continue here
oops :-)

[Dmitry Lomov (no reviews), 2014-04-16 17:50:58]

lgtm  (except stale TODO of course)

[Jakob Kummerow, 2014-04-17 09:56:00]

Committed patchset #2 manually as r20836 (presubmit successful).