Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: content/browser/accessibility/browser_accessibility.h

Issue 2393123002: Implement caching asynchronous accessibility hit testing. (Closed)
Patch Set: Made test more robust Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/accessibility/browser_accessibility.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/accessibility/browser_accessibility.h
diff --git a/content/browser/accessibility/browser_accessibility.h b/content/browser/accessibility/browser_accessibility.h
index c9c577700cdfb6dc650c4b8db419502c8874c69d..09c80746072500b38aafd9deeb201ebd0e946291 100644
--- a/content/browser/accessibility/browser_accessibility.h
+++ b/content/browser/accessibility/browser_accessibility.h
@@ -185,9 +185,13 @@ class CONTENT_EXPORT BrowserAccessibility {
int GetWordStartBoundary(int start,
ui::TextBoundaryDirection direction) const;
- // Returns the deepest descendant that contains the specified point
- // (in global screen coordinates).
- BrowserAccessibility* BrowserAccessibilityForPoint(const gfx::Point& point);
+ // This is an approximate hit test that only uses the information in
+ // the browser process to compute the correct result. It will not return
+ // correct results in many cases of z-index, overflow, and absolute
+ // positioning, so BrowserAccessibilityManager::CachingAsyncHitTest
+ // should be used instead, which falls back on calling ApproximateHitTest
+ // automatically.
+ BrowserAccessibility* ApproximateHitTest(const gfx::Point& screen_point);
// Marks this object for deletion, releases our reference to it, and
// nulls out the pointer to the underlying AXNode. May not delete
« no previous file with comments | « no previous file | content/browser/accessibility/browser_accessibility.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698