Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2393113003: test:

Created:
4 years, 2 months ago by zino
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

test: PaymentRequest: Implement payer info editor for payer name. Rename existing ContactEditor to PayerInfoEditor and then add a name field to collect payer name from user on UI. Related spec change: https://github.com/w3c/browser-payment-api/pull/270 BUG=648051 patch from issue 2368073002 at patchset 140001 (http://crrev.com/2368073002#ps140001)

Patch Set 1 #

Patch Set 2 : test: #

Patch Set 3 : test: #

Patch Set 4 : test: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+570 lines, -1186 lines) Patch
D chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillContact.java View 1 chunk +0 lines, -74 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPayerInfo.java View 1 chunk +94 lines, -0 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java View 1 chunk +0 lines, -167 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/EditorBase.java View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/payments/PayerInfoEditor.java View 5 chunks +67 lines, -19 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 10 chunks +58 lines, -50 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorModel.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentInformation.java View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java View 16 chunks +42 lines, -42 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 1 3 chunks +7 lines, -7 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java View 1 chunk +0 lines, -82 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java View 1 chunk +0 lines, -202 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailTest.java View 2 chunks +4 lines, -4 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java View 1 chunk +0 lines, -73 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteEmailTest.java View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompletePayerInfoDetailsTest.java View 1 2 2 chunks +17 lines, -17 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompletePhoneTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMultipleContactDetailsTest.java View 1 chunk +0 lines, -93 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMultiplePayerInfoDetailsTest.java View 1 2 3 2 chunks +18 lines, -16 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNameAndFreeShippingTest.java View 3 chunks +9 lines, -9 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNameTest.java View 3 chunks +19 lines, -19 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPayerInfoDetailsAndFreeShippingTest.java View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPayerInfoDetailsTest.java View 6 chunks +39 lines, -39 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneTest.java View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java View 1 2 3 4 chunks +10 lines, -9 lines 0 comments Download
D chrome/android/junit/src/org/chromium/chrome/browser/payments/AutofillContactTest.java View 1 chunk +0 lines, -86 lines 0 comments Download
A chrome/android/junit/src/org/chromium/chrome/browser/payments/AutofillPayerInfoTest.java View 1 chunk +128 lines, -0 lines 0 comments Download
D chrome/test/data/android/payments/contact_details.js View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/test/data/android/payments/contact_details_and_free_shipping.js View 1 chunk +0 lines, -50 lines 0 comments Download
A + chrome/test/data/android/payments/name.js View 1 chunk +4 lines, -5 lines 0 comments Download
A + chrome/test/data/android/payments/name_and_free_shipping.js View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/test/data/android/payments/payer_info_details.js View 1 chunk +4 lines, -2 lines 0 comments Download
A + chrome/test/data/android/payments/payer_info_details_and_free_shipping.js View 1 chunk +4 lines, -4 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_contact_details_and_free_shipping_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_contact_details_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
A + chrome/test/data/android/payments/payment_request_name_and_free_shipping_test.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/test/data/android/payments/payment_request_name_test.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/test/data/android/payments/payment_request_payer_info_details_and_free_shipping_test.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/test/data/android/payments/payment_request_payer_info_details_test.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (16 generated)
zino
The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run
4 years, 2 months ago (2016-10-05 16:25:53 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393113003/1
4 years, 2 months ago (2016-10-05 16:26:24 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-05 16:38:07 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/274270)
4 years, 2 months ago (2016-10-05 16:38:07 UTC) #4
zino
The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run
4 years, 2 months ago (2016-10-07 17:10:59 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393113003/20001
4 years, 2 months ago (2016-10-07 17:11:13 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-07 17:21:11 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/276534)
4 years, 2 months ago (2016-10-07 17:21:14 UTC) #8
zino
The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run
4 years, 2 months ago (2016-10-07 18:12:42 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393113003/40001
4 years, 2 months ago (2016-10-07 18:13:21 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-07 18:25:43 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/276613)
4 years, 2 months ago (2016-10-07 18:25:44 UTC) #12
zino
The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run
4 years, 2 months ago (2016-10-08 00:42:00 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393113003/60001
4 years, 2 months ago (2016-10-08 00:42:37 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-08 00:53:53 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-08 00:53:54 UTC) #16 
Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Powered by Google App Engine
This is Rietveld 408576698