third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp - Issue 2393113002: ImageResource: Reset the encoded image size after receiving all data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

Issue 2393113002: ImageResource: Reset the encoded image size after receiving all data (Closed)

Patch Set: Address on yhirano's review Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

diff --git a/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp b/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

index 00c2c99dcdcfd5fe9fc4039bd927f388303bd5fe..82c50c5f15835c8c9b35ba5d2e81dfcc9ab4c868 100644

--- a/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

+++ b/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

@@ -348,7 +348,9 @@ TEST(ImageResourceTest, DecodedDataRemainsWhileHasClients) {

nullptr);

cachedImage->appendData(reinterpret_cast<const char*>(jpeg.data()),

jpeg.size());

+ EXPECT_NE(0u, cachedImage->encodedSizeMemoryUsage());

cachedImage->finish();

+ EXPECT_EQ(0u, cachedImage->encodedSizeMemoryUsage());

EXPECT_FALSE(cachedImage->errorOccurred());

ASSERT_TRUE(cachedImage->hasImage());

EXPECT_FALSE(cachedImage->getImage()->isNull());