Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2393083003: [wasm] Small memory size crashes.

Created:
4 years, 2 months ago by bradnelson
Modified:
4 years, 2 months ago
Reviewers:
gdeepti, titzer, bradn
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Small memory size crashes. This crashes with: Fatal error in ../../src/assembler.cc, line 356 Check failed: new_size >= offset (1 vs. 3). LOG=N BUG= R=gdeepti@chromium.org,titzer@chromium.org

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M test/mjsunit/wasm/module-memory.js View 1 chunk +12 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
bradn
4 years, 2 months ago (2016-10-05 08:27:21 UTC) #2
titzer
lgtm
4 years, 2 months ago (2016-10-05 08:30:00 UTC) #3
bradn
No no, you misunderstand. This crash, haven't fixed, was hoping gdeepti could take a look?
4 years, 2 months ago (2016-10-05 08:41:29 UTC) #4
titzer
On 2016/10/05 08:41:29, bradn wrote: > No no, you misunderstand. > This crash, haven't fixed, ...
4 years, 2 months ago (2016-10-05 08:48:27 UTC) #5
gdeepti
4 years, 2 months ago (2016-10-07 02:50:52 UTC) #6
https://codereview.chromium.org/2393083003/diff/1/test/mjsunit/wasm/module-me...
File test/mjsunit/wasm/module-memory.js (right):

https://codereview.chromium.org/2393083003/diff/1/test/mjsunit/wasm/module-me...
test/mjsunit/wasm/module-memory.js:47: var buffer = new ArrayBuffer(1);
Following up from offline discussions, this test should not pass because the 
 - Memory is not aligned to page size. 
 - Imported memory should be in the form of WebAssembly.Memory object

I will follow up to add checks in Instantiate/GrowMemory/MemorySize methods for
the memory to be aligned to page size.

Powered by Google App Engine
This is Rietveld 408576698