[Remoting Android] Fading transition animation for desktop actionbar

[Remoting Android] Fading transition animation for desktop actionbar

This CL adds fade-in fade-out transition animation for the desktop actionbar.

BUG=650817
Committed: https://crrev.com/5ccf9e6daf99348a6cb6b40349c6b98bea8491e3
Cr-Commit-Position: refs/heads/master@{#423365}

[Yuwei, 2016-10-05 22:03:54]

yuweih@chromium.org changed reviewers:
+ joedow@chromium.org

[Yuwei, 2016-10-05 22:03:55]

PTAL

[joedow, 2016-10-05 22:10:25]

https://codereview.chromium.org/2393073003/diff/40001/remoting/android/java/s...
File remoting/android/java/src/org/chromium/chromoting/Desktop.java (right):

https://codereview.chromium.org/2393073003/diff/40001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:54: /** Animation
duration for fade-in and fade-out. */
I'd change this to 'Duration for fade-in and fade-out animations for the
ActionBar.'

https://codereview.chromium.org/2393073003/diff/40001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:86: private
Animation createAnimation(int animationId) {
rename to 'createToolbarVisibilityAnimation'?  It is pretty specific to the
ActionBar/Toolbar.

I'm not actually sure a helper method is cleaner than just creating the
animation inline with the call to use it.  If you decide to keep the method, I'd
move it below the public methods on the class.

[Yuwei, 2016-10-05 22:21:25]

Patchset #4 (id:60001) has been deleted

[Yuwei, 2016-10-05 22:22:22]

PTAL

https://codereview.chromium.org/2393073003/diff/40001/remoting/android/java/s...
File remoting/android/java/src/org/chromium/chromoting/Desktop.java (right):

https://codereview.chromium.org/2393073003/diff/40001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:54: /** Animation
duration for fade-in and fade-out. */
On 2016/10/05 22:10:25, joedow wrote:
> I'd change this to 'Duration for fade-in and fade-out animations for the
> ActionBar.'

Done.

https://codereview.chromium.org/2393073003/diff/40001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:86: private
Animation createAnimation(int animationId) {
On 2016/10/05 22:10:25, joedow wrote:
> rename to 'createToolbarVisibilityAnimation'?  It is pretty specific to the
> ActionBar/Toolbar.
> 
> I'm not actually sure a helper method is cleaner than just creating the
> animation inline with the call to use it.  If you decide to keep the method,
I'd
> move it below the public methods on the class.

Done.

[joedow, 2016-10-05 22:49:14]

lgtm

[Yuwei, 2016-10-05 22:50:40]

The CQ bit was checked by yuweih@chromium.org

[commit-bot: I haz the power, 2016-10-05 22:51:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 00:59:00]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-10-06 01:00:53]

Description was changed from

==========
[Remoting Android] Fading transition animation for desktop actionbar

This CL adds fade-in fade-out transition animation for the desktop actionbar.

BUG=650817
==========

to

==========
[Remoting Android] Fading transition animation for desktop actionbar

This CL adds fade-in fade-out transition animation for the desktop actionbar.

BUG=650817

Committed: https://crrev.com/5ccf9e6daf99348a6cb6b40349c6b98bea8491e3
Cr-Commit-Position: refs/heads/master@{#423365}
==========

[commit-bot: I haz the power, 2016-10-06 01:00:56]

Patchset 4 (id:??) landed as
https://crrev.com/5ccf9e6daf99348a6cb6b40349c6b98bea8491e3
Cr-Commit-Position: refs/heads/master@{#423365}