Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2393073003: [Remoting Android] Fading transition animation for desktop actionbar (Closed)

Created:
4 years, 2 months ago by Yuwei
Modified:
4 years, 2 months ago
Reviewers:
joedow
CC:
chromium-reviews, agrieve+watch_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remoting Android] Fading transition animation for desktop actionbar This CL adds fade-in fade-out transition animation for the desktop actionbar. BUG=650817 Committed: https://crrev.com/5ccf9e6daf99348a6cb6b40349c6b98bea8491e3 Cr-Commit-Position: refs/heads/master@{#423365}

Patch Set 1 #

Patch Set 2 : Fix some bug #

Patch Set 3 : Not using AnimationListener, which made onSystemUiVisibilityChange flaky (why?) #

Total comments: 4

Patch Set 4 : Reviewer's Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/Desktop.java View 1 2 3 4 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yuwei
PTAL
4 years, 2 months ago (2016-10-05 22:03:55 UTC) #2
joedow
https://codereview.chromium.org/2393073003/diff/40001/remoting/android/java/src/org/chromium/chromoting/Desktop.java File remoting/android/java/src/org/chromium/chromoting/Desktop.java (right): https://codereview.chromium.org/2393073003/diff/40001/remoting/android/java/src/org/chromium/chromoting/Desktop.java#newcode54 remoting/android/java/src/org/chromium/chromoting/Desktop.java:54: /** Animation duration for fade-in and fade-out. */ I'd ...
4 years, 2 months ago (2016-10-05 22:10:25 UTC) #3
Yuwei
PTAL https://codereview.chromium.org/2393073003/diff/40001/remoting/android/java/src/org/chromium/chromoting/Desktop.java File remoting/android/java/src/org/chromium/chromoting/Desktop.java (right): https://codereview.chromium.org/2393073003/diff/40001/remoting/android/java/src/org/chromium/chromoting/Desktop.java#newcode54 remoting/android/java/src/org/chromium/chromoting/Desktop.java:54: /** Animation duration for fade-in and fade-out. */ ...
4 years, 2 months ago (2016-10-05 22:22:22 UTC) #5
joedow
lgtm
4 years, 2 months ago (2016-10-05 22:49:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393073003/80001
4 years, 2 months ago (2016-10-05 22:51:07 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 2 months ago (2016-10-06 00:59:00 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 01:00:56 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5ccf9e6daf99348a6cb6b40349c6b98bea8491e3
Cr-Commit-Position: refs/heads/master@{#423365}

Powered by Google App Engine
This is Rietveld 408576698