Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Issue 2393053002: Fix reentrancy crash in createWindowHelper (Closed)

Created:
4 years, 2 months ago by Nate Chapin
Modified:
4 years, 2 months ago
Reviewers:
dcheng
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix reentrancy crash in createWindowHelper BUG=619870 TEST=http/tests/loading/window-open-onblur-reentrancy.html Committed: https://crrev.com/0a16bdd9b4f92ea68b2b40bfba075e8ba0a6fa83 Cr-Commit-Position: refs/heads/master@{#424482}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, --1 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/loading/window-open-onblur-reentrancy.html View 1 chunk +10 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/loading/window-open-onblur-reentrancy-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/page/CreateWindow.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Nate Chapin
4 years, 2 months ago (2016-10-05 17:28:32 UTC) #6
Nate Chapin
On 2016/10/05 17:28:32, Nate Chapin wrote: It's not clear to me what the "right" behavior ...
4 years, 2 months ago (2016-10-05 17:29:31 UTC) #7
dcheng
Fun. LGTM
4 years, 2 months ago (2016-10-05 18:01:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393053002/1
4 years, 2 months ago (2016-10-11 16:39:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 17:58:52 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 18:00:52 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a16bdd9b4f92ea68b2b40bfba075e8ba0a6fa83
Cr-Commit-Position: refs/heads/master@{#424482}

Powered by Google App Engine
This is Rietveld 408576698